Closed Bug 848446 Opened 11 years ago Closed 11 years ago

Add reviewer flags to ES index

Categories

(Marketplace Graveyard :: Search, defect, P2)

Product:
Marketplace Graveyard
Component:
Search
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2013-07-04

People

(Reporter: robhudson, Assigned: mat)

References

Details

(Whiteboard: p=1) 

      No description provided.
Assignee: nobody → robhudson.mozbugs
Whiteboard: p=1
Blocks: 852302
Flags are:
* escalated
* has comment
* info requested

One there, hook up to the reviewer tools search.
Blocks: 857208
No longer blocks: 842693
Priority: -- → P2
https://github.com/mozilla/zamboni/commit/0a6e265
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Summary: Add reviewer flags to ES → Add reviewer flags to search API
Target Milestone: --- → 2013-04-25
Actually, let me re-open. I only added to the API results. These still need to be added to the index if we want to be able to filter by them. Re-opening for that.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Add reviewer flags to search API → Add reviewer flags to ES index
Target Milestone: 2013-04-25 → ---
Stealing this bug since there is some overlap with bug 842831.
Assignee: robhudson.mozbugs → mpillard
Status: REOPENED → ASSIGNED
Blocks: 842831
Fixed in https://github.com/mozilla/zamboni/commit/5d4a9d00e7aad7b76f331ea7d1c28b682192fe04

Steps to reproduce:
- Go to the reviewer tools on -dev and load up the advanced search.
- It should now be possible to search for apps containing editors comments, or apps with more info requested, or escalated apps.
- All these searches should return correct results depending on those new criteria.
- Icons should appear in both the queue and search results corresponding to those flags as well.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-07-04
Verified as fixed in https://marketplace-dev.allizom.org/reviewers/apps/queue/ on FF25 (Win 7).
Postfix screencast http://screencast.com/t/COBDAzOm
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.