848447 - os.path.sep issues in xpcshell mach commands

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I noticed some issues in the path handling in XPCShellRunner.

For example, it does not handle paths on windows that end in "/" because it uses code that checks for a trailing os.path.sep (which is "\" on Windows).  The code to get a relative path also fails sometimes because self.topsrcdir may use different path separators than the test_file argument.

This code also has problems when run in a directory other than $topsrcdir (for example, when using bug 840588 to run mach in a different directory), because the os.path.isfile and os.path.isdir checks assume that $PWD == $topsrcdir.

This patch uses the new mozpack.path module to ensure that comparisons are all done using "/" as the path separator, and it makes the code explicitly handle paths relative to $topsrcdir.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 721782 [details] [diff] [review]
patch

Review of attachment 721782 [details] [diff] [review]:
-----------------------------------------------------------------

I really haven't reviewed any mach code yet. I probably should, but you're better off with gps for now.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 721782 [details] [diff] [review]
patch

Review of attachment 721782 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f37c3553015e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f37c3553015e