848480 - Don't DOS ourselves when AJAX returns 500s

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect, P3)

Description

[Erik Rose [:erik][:erikrose]]

If a live search returns a 500 error from the AJAX call, the JS just keeps sending the same request, over and over. Don't send any more requests until the query changes.

Comment 1

[Nicholas [:tanji]]

Hi guys,

I think this should do it. Let me know if this does the job. I requested a pull for this.

https://github.com/mozilla/dxr/pull/148

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/56d79f0ab13daf41c42cc4cd746773cfa2eabc82
Don't retry fetching results on failure, 500 or otherwise. Fix bug 848480.

I'm not sure why we were being so failure-tolerant in the JS before; perhaps the CGI failed or timed out a lot. With WSGI, we no longer have timeouts to worry about, and, if we have other failures, we should solve the root problem.

If there is an error, the user can "retry" just by changing the search query or hitting Return, both of which should be natural reactions.