Closed
Bug 848507
Opened 11 years ago
Closed 11 years ago
Support DXR searches
Categories
(Firefox Build System :: Mach Core, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla22
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
1.13 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #721846 -
Flags: review?(gps)
Comment 1•11 years ago
|
||
Comment on attachment 721846 [details] [diff] [review] Patch (v1) Review of attachment 721846 [details] [diff] [review]: ----------------------------------------------------------------- Please land with "DONTBUILD (NPOTB)" in the commit message. ::: tools/mach_commands.py @@ +22,5 @@ > webbrowser.open_new_tab(uri) > > + @Command('dxr', help='Search for something in DXR.') > + @CommandArgument('term', nargs='+', help='Term(s) to search for.') > + def mxr(self, term): def dxr (I'm surprised this even compiles!)
Attachment #721846 -
Flags: review?(gps) → review+
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to comment #1) > Comment on attachment 721846 [details] [diff] [review] > --> https://bugzilla.mozilla.org/attachment.cgi?id=721846 > Patch (v1) > > Review of attachment 721846 [details] [diff] [review]: > ----------------------------------------------------------------- > > Please land with "DONTBUILD (NPOTB)" in the commit message. > > ::: tools/mach_commands.py > @@ +22,5 @@ > > webbrowser.open_new_tab(uri) > > > > + @Command('dxr', help='Search for something in DXR.') > > + @CommandArgument('term', nargs='+', help='Term(s) to search for.') > > + def mxr(self, term): > > def dxr > > (I'm surprised this even compiles!) What, you assumed I tested this? ;-)
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f64b3dbe0b53
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•