Closed Bug 84851 Opened 23 years ago Closed 8 years ago

Move all component names to central place (brand.dtd etc.)

Categories

(Core Graveyard :: Tracking, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE
mozilla1.8alpha1

People

(Reporter: BenB, Assigned: chofmann)

References

(Depends on 1 open bug)

Details

(Keywords: meta)

Attachments

(1 file)

Mozilla, Netscape 6, Beonex Communicator and other derivates don't necessarily
agree on the component names (listed below).(For example, Netscape may want to
use "Mail" / "News" for Mailnews, but Mozilla and Beonex may want a more unique
name.

However, currently, they are "hardcoded" all other place in the locale files,
which makes it practically improssible to change them.

Subject of this bug: Each component name must appear at most 2 times (once in
.dtd, once in .properties) in the source.

Component names:
- Navigator
- Composer / Editor
- Mail and News
- Mail
- News
- Address Book
- ChatZilla
For now, assigning to myself.

If anybody decides to work on that, either file blocking bugs for components or
take this bug (if you want to do it "all at once").

There is already a bug about this for Mailnews.
Assignee: chofmann → ben.bucksch
Depends on: 51153
Technically, this is not a problem: We do that for "Mozilla" already, using
entities (in DTDs), e.g. &brandShortName;. Similarily, we could have
&mailShortName; etc.
Adding meta keyword. Sorry for the spam!
Keywords: meta
Blocks: 232794
No longer blocks: 232794
Depends on: 232794
I'm willing to implement this if nobody else is.
Moving this bug to my plate. Not sure why this is tracking. If anybody can 
think of a better component, feel free to change it (for QA purposes).
Assignee: ben.bucksch → rlk
just to note:

"Composer" is at
http://lxr.mozilla.org/seamonkey/source/editor/ui/composer/locale/en-US/editor.dtd#25
"Address Book" is at
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/locale/en-US/abMainWindow.dtd#22

Mail & Newsgroups doesn't seem to have a specific location. Is there any other
moz apps that need brand names in brand.dtd?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha
Comment on attachment 155530 [details] [diff] [review]
Moves all components to brand.dtd

Neil, can you review this?
Attachment #155530 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 155530 [details] [diff] [review]
Moves all components to brand.dtd

The IRC changes are no good because it's an extension. Also you'll need to talk
to mscott to see how this will affect Thunderbird. Are you intending to make
further changes, for instance there are only two Composer changes here,
although the name appears in several other files.
Attachment #155530 - Flags: review?(neil.parkwaycc.co.uk) → review-
(In reply to comment #9)
> (From update of attachment 155530 [details] [diff] [review])
> The IRC changes are no good because it's an extension. Also you'll need to talk
> to mscott to see how this will affect Thunderbird. Are you intending to make
> further changes, for instance there are only two Composer changes here,
> although the name appears in several other files.
> 

what files? (other than the help docs) LXR didn't find any more.

I'll talk to mscott about Thunderbird.
--> default owners
Assignee: rlk → chofmann
Status: ASSIGNED → NEW
(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 155530 [details] [diff] [review])
> > The IRC changes are no good because it's an extension. Also you'll need to talk
> > to mscott to see how this will affect Thunderbird. Are you intending to make
> > further changes, for instance there are only two Composer changes here,
> > although the name appears in several other files.
> > 
> 
> what files? (other than the help docs) LXR didn't find any more.
> 
> I'll talk to mscott about Thunderbird.
Marking all tracking bugs which haven't been updated since 2014 as INCOMPLETE.
If this bug is still relevant, please reopen it and move it into a bugzilla component related to the work
being tracked. The Core: Tracking component will no longer be used.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: