Created attachment 721863 [details] Layout Guide Please add a favicon underlay when displaying the favicons in lists. Underlay and visual guide attached with this bug.
Attachment #722784 - Flags: feedback? → feedback?(pabratowski)
This looks great! Thank you Sam.
blocking-b2g: --- → leo?
Whiteboard: visual design, YEDO → visual design, yedo
Attachment #722784 - Flags: feedback?(pabratowski) → review?(bfrancis)
Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1
tracking-b2g18: ? → +
Ben, can you review? We're hoping to get this reviewed by end of week so it can make it into v1.1. Thanks!
Comment on attachment 722784 [details] Patch Thanks for the patch and sorry for the long review time, I reviewed the patch on Github and I just have a couple of nits. If you remove the console.log line I think we're good :) Where's the pull request?
Attachment #722784 - Flags: review?(bfrancis) → review+
Oops here is the PR https://github.com/mozilla-b2g/gaia/pull/8674
thanks Ben. Landed in master: https://github.com/mozilla-b2g/gaia/commit/07706f330c0f556f21e63841dbbaa6713cbc9666
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: visual design, yedo → visual design, yedo, uxbranch, landed in uxbranch
Verified in master. uplift +1! Master build : 2013-04-05-03-05-43 name="mozilla-central" revision="55f9e3e3dae7" name="integration/gaia-central" revision="2005e026bdae" "gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550" "gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641" Unagi
Status: RESOLVED → VERIFIED
Comment on attachment 722784 [details] Patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: This increases the UX as it may be favicon with colors that will not have enough contrast with the background Testing completed: Risk to taking this patch (and alternatives if risky): Low risk, just adding a new background to each item. String or UUID changes made by this patch:
Attachment #722784 - Flags: approval-gaia-v1?
Attachment #722784 - Flags: approval-gaia-v1? → approval-gaia-v1+
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 07706f330c0f556f21e63841dbbaa6713cbc9666 <RESOLVE MERGE CONFLICTS> git commit
Sam/Pavel, another conflict issue with uplift, can one of you take a look? Thanks!
status-b2g18: affected → fixed
You need to log in before you can comment on or make changes to this bug.