Closed Bug 848727 Opened 12 years ago Closed 12 years ago

Email app HTML contains duplicate IDs

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: zcampbell, Unassigned)

Details

The Email app contains a bunch of 'templates' coded into the HTML. The elements are copied with javascript to become alert/confirmation boxes and so forth that are presented to the user. They are children of: div#templates https://github.com/mozilla-b2g/gaia/blob/master/apps/email/index.html#L78 However when they are copied and used as confirmation boxes the ID attributes are copied. This means that elements with duplicate IDs exist in the HTML and is violation of the W3C standard that states that element IDs must be unique. It also means the app has poor testability.
Assignee: bugmail → nobody
Is this still valid? I just checked and line 78 doesn't event exist now.
Flags: needinfo?
All the templates now live in separate HTML files that are instantiated via innerHTML on demand. So, in practice, the duplicates that this bug were logged against will never exist simultaneously because they are for modal dialogs and so won't be present in the tree at the same time. Other UI templates may be instantiated at the same time, but we don't use id's anywhere else for hygiene reasons; these had slipped through for review/time pressure reasons. So if you're okay with it, feel free to resolve this worksforme.
Flags: needinfo?
(In reply to Andrew Sutherland (:asuth) from comment #2) > All the templates now live in separate HTML files that are instantiated via > innerHTML on demand. So, in practice, the duplicates that this bug were > logged against will never exist simultaneously because they are for modal > dialogs and so won't be present in the tree at the same time. Other UI > templates may be instantiated at the same time, but we don't use id's > anywhere else for hygiene reasons; these had slipped through for review/time > pressure reasons. So if you're okay with it, feel free to resolve this > worksforme. Okay, great =)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.