848730 - [Cost Control] Reset dialogs' transitions are incorrect

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

STR:
1 - Open Usage
2 - Go to settings
3 - Tap on Reset

Expected:
Dialogs should fade in when appearing and fade out when disposing.

Current:
Dialogs appear from bottom and are disposed to the bottom

Comment 1

[Salvador de la Puente González [:salva]]

Attachment: Implementing fade in / fade out for reset confirmations.

Knowing that this should be implemented by animations, it is a little bit overkilling to change current ViewManager to accept animations when transitions sufficce. Opening another bug to track this issue.

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

I totally understand and support this decision ;-) In fact, for the time being the only app using the overlays animations (http://buildingfirefoxos.com/transitions.html#prompts) is the Communications app.

Apart from this, I have reviewed and tested your code and you have my r+ and my blessings :-p

Comment 3

[Salvador de la Puente González [:salva]]

Master: 2874c6a3b812664ff113ecec55e92485615c1d51

Not affecting l10n, low impact and low risk. It could be considered as a follow up of bug 841439.

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 722278 [details]
Implementing fade in / fade out for reset confirmations.

Bug caused by (feature/regressing bug #): this one
User impact if declined: visually noticeable
Testing completed: yes
Risk to taking this patch (and alternatives if risky): superlow
String or UUID changes made by this patch: none

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 722278 [details]
Implementing fade in / fade out for reset confirmations.

Tracking so that this is uplifted after a couple of days of bake time.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 2874c6a3b812664ff113ecec55e92485615c1d51 as:
v1-train: 7936e46316cd22615078211b1982069d2b8327a5