Closed Bug 848754 Opened 9 years ago Closed 9 years ago

GC: Remove relaxed root checking infrastructure

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

No description provided.
Attached patch Proposed fixSplinter Review
Attachment #722238 - Flags: review?(terrence)
Comment on attachment 722238 [details] [diff] [review]
Proposed fix

Review of attachment 722238 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, looks perfect. Please give it a try run before pushing to make double-sure that we're actually fast enough and have the right SkipRoot coverage for this to work now.
Attachment #722238 - Flags: review?(terrence) → review+
So this is does actually cause timeouts in v8-v5/check-crypto.js, one of the tests that was using the relaxed rooting:

~/work/rooting/js/src$ JS_GC_ZEAL=6 ./jit-test/jit_test.py --tbpl rooting-build/js 
...
TIMEOUTS:
    --no-ion --no-jm --no-ti /home/jon/work/rooting/js/src/jit-test/tests/v8-v5/check-crypto.js
    --no-ion --no-jm /home/jon/work/rooting/js/src/jit-test/tests/v8-v5/check-crypto.js
https://hg.mozilla.org/mozilla-central/rev/b7c5623df228
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.