848757 - Mach command for `make package-tests`

Status: RESOLVED WORKSFORME

(Firefox Build System :: Mach Core, enhancement)

Description

[Ed Morley [:emorley]]

+++ This bug was initially created as a clone of Bug #820179 +++

Comment 1

[James Graham [:jgraham]]

Attachment: bug848757.diff

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8699475 [details] [diff] [review]
bug848757.diff

Review of attachment 8699475 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +1164,5 @@
>              pass_thru=True, append_env=extra_env)
>  
>  @CommandProvider
> +class PackageTests(MachCommandBase):
> +    """Package the test files."""

This is ok, but the new way to do this is have a short string in the description argument (shown by |mach help|), and a docstring for the method implementing the command if a longer message is needed (shown by |mach help <command>|). I don't think the short docstrings for the classes around this file are adding anything.

@@ +1171,5 @@
> +        description='Package the tests into tests.zip files used in CI')
> +    def package_tests(self):
> +        ret = self._run_make(directory=".", target='package-tests', ensure_exit_code=False)
> +        if ret == 0:
> +            self.notify('Packaging complete')

'Packaging tests complete' ?

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Figured out at some point that |./mach build package-tests| works fine for this.