848770 - Choose the best compression settings automagically for seekable zstreams (szip)

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Choose the best compression settings automagically for seekable zstreams (szip)

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 723419 [details] [diff] [review]
Choose the best compression settings automagically for seekable zstreams (szip)

Review of attachment 723419 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sane too me.

::: mozglue/linker/szip.cpp
@@ +274,5 @@
> +    if (do_compress(*origData, tmpBuf, NULL, 0, f) == 0) {
> +      if (tmpBuf.GetLength() < outBuf.GetLength()) {
> +        outBuf.Resize(tmpBuf.GetLength());
> +        memcpy(static_cast<void *>(outBuf), static_cast<void *>(tmpBuf),
> +               tmpBuf.GetLength());

Factoring out this .Resize/memcpy idiom (a method in Buffer?) would be a good thing.  You could use it in FilteredBuffer and several places in this function.  (Maybe other places in this file, I didn't check.)

Comment 3

[Mike Hommey [:glandium]]

Attachment: Factor out Resize/memcpy

Comment 4

[Mike Hommey [:glandium]]

Landed in one piece.
https://hg.mozilla.org/integration/mozilla-inbound/rev/80944f366642

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/80944f366642