Closed Bug 848794 Opened 8 years ago Closed 8 years ago

Can't re-run Firefox stub installer after cancelling Install

Categories

(Firefox :: Installer, defect)

21 Branch
x86
Windows XP
defect
Not set
blocker

Tracking

()

VERIFIED FIXED
Firefox 22
Tracking Status
firefox20 --- verified
firefox21 --- verified
firefox22 --- verified
firefox-esr17 --- wontfix
b2g18 --- wontfix
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: virgil.dicu, Assigned: robert.strong.bugs)

References

Details

(Whiteboard: [stub+])

Attachments

(1 file)

Mozilla/5.0 (Windows NT 5.1; rv:19.0) Gecko/20130306 Firefox/21.0

STR:
1. Download the Firefox stub installer: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/
2. Double Click the downloaded entry.
3. Install
4. Select "Cancel" while the build is downloaded.
5. Double Click the downloaded entry and run.

Actual result: no action is performed - the stub installer doesn't start.
The Firefox process is still listed in the Task manager.
Is the file still present in the location where you downloaded it to?

Please try waiting 30 seconds after cancelling to see if it can launch then.
I think I am seeing this locally.
Whiteboard: [stub+]
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attached patch patch rev1Splinter Review
First off, thanks Virgil for catching this!

Brian, this fixes the cases where the stub installer wouldn't call RelativeGotoPage to exit. It also displays the download error messagebox when cancelling the installer during the download phase so if someone cancels they will hopefully download and install via the full installer. I fixed a couple of cases where the metrics ping data was incorrect as well.
Attachment #722641 - Flags: review?(netzen)
Severity: normal → blocker
Attachment #722641 - Flags: review?(netzen) → review+
Attachment #722641 - Flags: approval-mozilla-beta+
Attachment #722641 - Flags: approval-mozilla-aurora+
Pushed to mozilla-central
https://hg.mozilla.org/mozilla-central/rev/e6215e0357fa
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Used the build from 10/2 for verification. 

It's fixed in the sense that the process is now closed on exit. 

While canceling, though, the disconnect error is displayed (same error as in missing Internet connection - two options: OK and Cancel), which is a bit unexpected.

Is this intended?
(In reply to Virgil Dicu [:virgil] [QA] from comment #6)
> Used the build from 10/2 for verification. 
> 
> It's fixed in the sense that the process is now closed on exit. 

Which branch did you test? This is marked fixed for Beta, Aurora, and Nightly.

> While canceling, though, the disconnect error is displayed (same error as in
> missing Internet connection - two options: OK and Cancel), which is a bit
> unexpected.

I would say file a follow-up bug for the error. I wouldn't consider this a blocker for the experiment though.
(In reply to Virgil Dicu [:virgil] [QA] from comment #6)
> Used the build from 10/2 for verification. 
> 
> It's fixed in the sense that the process is now closed on exit. 
> 
> While canceling, though, the disconnect error is displayed (same error as in
> missing Internet connection - two options: OK and Cancel), which is a bit
> unexpected.
> 
> Is this intended?
Yes, it is intended. No need for a followup bug
Thanks, Robert. Marking as verified considering comment 8.

Verified fixed with latest Nightly, Aurora and Beta stub installers. Works as expected. Cancelling closes the process and one can re-launch the installer without problems.
You need to log in before you can comment on or make changes to this bug.