bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

action chains returns ok even if there was a failure

RESOLVED FIXED in Firefox 22

Status

Testing
Marionette
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mdas, Assigned: Ann(Yiming))

Tracking

Trunk
mozilla22
Points:
---

Firefox Tracking Flags

(firefox22 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

In marionette-listener.js, if you're running and action chain and the element is not visible, then sendError will send a response back to the client, which is what we want, but in the actionChain() function, it will call sendOk regardless. We must change it so it will only send either sendError or sendOk, but not both. You can do this by either having the actions() function return true if it succeeded and false if there was a failure. Then actionChain will call sendOk only if actions() succeeded.
(Assignee)

Comment 1

5 years ago
Created attachment 722502 [details] [diff] [review]
ReturnFix
Attachment #722502 - Flags: review?(mdas)
(Assignee)

Comment 2

5 years ago
Created attachment 722956 [details] [diff] [review]
removeMultiTouchFix
Attachment #722502 - Attachment is obsolete: true
Attachment #722502 - Flags: review?(mdas)
Attachment #722956 - Flags: review?(mdas)
Comment on attachment 722956 [details] [diff] [review]
removeMultiTouchFix

Review of attachment 722956 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, I didn't realize there was a checkTimer being used when I first wrote the description.

Here, we have the same problem in this patch as in in the multitouch patch (the last section here: https://bugzilla.mozilla.org/show_bug.cgi?id=841101#c5), where, if 'wait' is called last, we will implicitly return before we complete 'wait' case since we are usin the checkTimer asynchronous call. Can you think of a way around this?
Attachment #722956 - Flags: review?(mdas) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 725032 [details] [diff] [review]
return
Attachment #722956 - Attachment is obsolete: true
Attachment #725032 - Flags: review?(mdas)
Attachment #725032 - Flags: review?(mdas) → review+
https://hg.mozilla.org/mozilla-central/rev/2642614673d0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6adf1cb77b28
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → fixed
status-firefox22: --- → fixed
You need to log in before you can comment on or make changes to this bug.