Talos-other crashes when Components disappears for content

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
See bug 790732 comment 47. I think the problem is page_load_test/a11y/a11y.js. In particular, it touches |Components| before invoking enablePrivilege, which would otherwise have defined it on the window. Fix should be straightforward, but testing it will be a pain.
(Assignee)

Comment 1

6 years ago
https://tbpl.mozilla.org/?tree=Try&rev=ff6aeba6792f
Assignee: nobody → bobbyholley+bmo
ahh, at the root of talos run: python create_talos_zip.py.  This doesn't work on windows, but it does on osx and linux.
(Assignee)

Comment 3

6 years ago
Ok, this is green on talos-other. Uploading patch and flagging for review.
(Assignee)

Comment 4

6 years ago
Created attachment 723545 [details] [diff] [review]
Make a11y talos test Components-agnostic. v1
Attachment #723545 - Flags: review?(jmaher)
Comment on attachment 723545 [details] [diff] [review]
Make a11y talos test Components-agnostic. v1

Review of attachment 723545 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for writing and testing this!
Attachment #723545 - Flags: review?(jmaher) → review+
(Assignee)

Comment 6

6 years ago
Joel, can you take care of getting this landed?
Flags: needinfo?(jmaher)
http://hg.mozilla.org/build/talos/rev/1e4aec80d7b5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: needinfo?(jmaher)
Resolution: --- → FIXED
Depends on: 849911
You need to log in before you can comment on or make changes to this bug.