Closed
Bug 848998
Opened 11 years ago
Closed 11 years ago
Talos-other crashes when Components disappears for content
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
1.47 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
See bug 790732 comment 47. I think the problem is page_load_test/a11y/a11y.js. In particular, it touches |Components| before invoking enablePrivilege, which would otherwise have defined it on the window. Fix should be straightforward, but testing it will be a pain.
Assignee | ||
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=ff6aeba6792f
Assignee: nobody → bobbyholley+bmo
Comment 2•11 years ago
|
||
ahh, at the root of talos run: python create_talos_zip.py. This doesn't work on windows, but it does on osx and linux.
Assignee | ||
Comment 3•11 years ago
|
||
Ok, this is green on talos-other. Uploading patch and flagging for review.
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #723545 -
Flags: review?(jmaher)
Comment 5•11 years ago
|
||
Comment on attachment 723545 [details] [diff] [review] Make a11y talos test Components-agnostic. v1 Review of attachment 723545 [details] [diff] [review]: ----------------------------------------------------------------- thanks for writing and testing this!
Attachment #723545 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Joel, can you take care of getting this landed?
Flags: needinfo?(jmaher)
Comment 7•11 years ago
|
||
http://hg.mozilla.org/build/talos/rev/1e4aec80d7b5
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jmaher)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•