849026 - Task view: task-details-container appears with no task selected

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Decathlon]

Steps to reproduce:
- switch to task view, be sure to have some tasks in the list and close
  Thunderbird;
- restart Thunderbird.

->  no task is selected in the list after the restart but the task-detail-container (task details area, task toolbar buttons and task description area) is visible with toolbar buttons disabled and three priority labels "Low", "Normal" and "High" enabled and no other details.

As far as I can see this behavior has started with later versions of Lightning 2.0a2. Earlier versions don't show the task details without selected tasks, or they show it for a while during startup and immediately disappears.

Comment 1

[Decathlon]

Attachment: patch - v1

This patch should fix.
I also move the buttons of the task toolbar a bit upward in order to make the task details area more similar to the Thunderbird's email message area. I can't verify the effect on Linux and Mac (or if it's necessary on those platforms). Richard, could you please verify that?

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 722527 [details] [diff] [review]
patch - v1

First, the buttons and labels are no more visible, great.

Now to the button move: On Win7 this is now similar to the mail part. Unfortunately on XP the old padding is needed. When you put this rule in win-aero/calendar.css then this would work on both platforms.

I checked also Linux (here a padding-top: 1px; is needed) and OS X (padding-top: 2px;).

Code wise all is looking good and I give a r+. For the button positioning I'm giving a ui-r- for now.

Comment 3

[Decathlon]

Attachment: patch - v2

(In reply to Richard Marti [:Paenglab] from comment #2)

> Unfortunately on XP the old padding is needed. When you put this rule in
> win-aero/calendar.css then this would work on both platforms.
> 
> I checked also Linux (here a padding-top: 1px; is needed) and OS X
> (padding-top: 2px;).

This one should be right then.
Thanks for checking on the others platforms.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 725939 [details] [diff] [review]
patch - v2

This looks good now.

Comment 5

[Decathlon]

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/5e5d66057738

Fixed.