849077 - Use Django's forms for dashboard controls, instead of reinventing the wheel.

Status: RESOLVED WONTFIX

(Input Graveyard :: Code Quality, defect)

Description

[Michael Cooper [:mythmon]]

In Kitsune, I'm doing a bunch of graph stuff. It's fun. This time I chose to use Django's form elements instead of doing a bunch of input validation on my own. It was so much simpler, and a lot cleaner, and a lot less error prone.

We should do this on Fjord too. This would mean taking anything that the views in fjord.analytics.views that touches GET or POST data and replacing it with making a Django form, making it work with the same kind of data, and changing the code to use the form.

Comment 1

[deshrajdry]

I would like to work on this. Please assign it to me.

Comment 2

[Michael Cooper [:mythmon]]

Alright, it is yours. Let me know if you have any trouble with this.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Mike: This isn't marked as a mentored bug. Do you want to mentor him here?

Comment 4

[Michael Cooper [:mythmon]]

That was my plan, yes. He and I talked in irc before this. I probably should have mentioned that. I'll add the mentor bits.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

There's a mentor field now. I'll set it for you. Otherwise mhoye will eat your lunch.

Comment 6

[deshrajdry]

This bug requires huge changes in the code. After binding django form, it needs to replace the macro used in the template and write the new logic for displaying the fields which requires alot of changes to be done in analytics/dashboard.html and fjord/analytics/views.py . So use of django form will not bring the significant change and will consume alot of time and I think it should be closed as RESOLVED WONTFIX.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Mike: You opened this bug. Does comment #6 cover it? Or would you rather keep it open and reduce the scope a bit or change tack or something like that?

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tagging Mike with a needinfo for comment #7.

Comment 9

[Michael Cooper [:mythmon]]

I talked with deshrajdry while he was working on it. Since I filed the bug, the view has changed a lot, and making it use Django's form machinery would be a large change, like he said. I think that the code is good as it stands now.