Closed Bug 849086 Opened 11 years ago Closed 11 years ago

Remove unused CLASSNAME defines

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

jimb and I noticed that a lot of xpcom classes have CLASSNAME defines that aren't actually used anywhere[1].

bsmedberg says:
> they used to be using by XPCOM registration macros
> but I don't think they are any more
[...]
> you could just take them out and see if it builds

I tried taking them out, and we still build just fine, so I think they're unused.

[1] The defines in question:
https://mxr.mozilla.org/mozilla-central/search?string=define.*[_]CLASSNAME&regexp=1&case=1
Ignore the skia ones, since that's an upstream library; ignore the XPC_MAP_CLASSNAME and cyclecollection ones, which are actually used.
Attached patch fix v1Splinter Review
This built fine locally, but here's a try run as a sanity-check:
  https://tbpl.mozilla.org/?tree=Try&rev=f128dee1472b

Assuming it builds everywhere, I'll request review.
Comment on attachment 722613 [details] [diff] [review]
fix v1

Try looks green.
Attachment #722613 - Flags: review?(benjamin)
Attachment #722613 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/8c4e1ad6d30b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.