849174 - inline function declared as dllimport warning js jsfriendapi.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jacek Caban]

Attachment: fix

This is noisy in mingw builds and there is no reason to export an empty inline function.

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 722721 [details] [diff] [review]
fix

Hm, I think I did it this way so that it would match the |friend| declaration in AutoEnterPolicy (near the bottom of jsproxy.h). However, it looks like that's in an #ifdef DEBUG block. There might have been another reason, but I don't remember.

Please do a "try: -b do -p all -u none -t none" run before landing this. r=bholley if it builds on all platforms.

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 722721 [details] [diff] [review]
fix

Err, s/-/+/

Comment 3

[Jacek Caban]

Thanks for the review. It seems green on try:

https://tbpl.mozilla.org/?tree=Try&rev=46e7e0428e3c

(I'm still waiting for win debug build, but that one shouldn't be affected).

Comment 4

[Jacek Caban]

It's all green on try.

http://hg.mozilla.org/integration/mozilla-inbound/rev/c9924ded22f2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c9924ded22f2