Unable to set requested flag without editbugs permission

REOPENED
Assigned to

Status

()

REOPENED
6 years ago
5 years ago

People

(Reporter: caitlin.potter, Assigned: dkl)

Tracking

Production

Details

(Reporter)

Description

6 years ago
I had been asked for feedback this morning
jacek: feedback? (caitlin.potter)

But I was not able to set my feedback until asking about it and being granted editbugs permission (which I'm not sure I need).

:ted had said on IRC that extra permissions should not be required for setting requested review/feedback flags on a bug.
(Reporter)

Updated

6 years ago
Version: 4.2 → 4.2.5
(Assignee)

Comment 1

6 years ago
I am thinking this is due to the recent change to Bugzilla::Flag->set_flag that calls out to $bug->check_can_change_field where we were not doing that before 4.2. We will need to add some code the the BMO extension to allow the change if the user is the flags requestee. Will work on a patch.

dkl
Assignee: attach-and-request → dkl
Status: NEW → ASSIGNED
Component: Attachments & Requests → Extensions: BMO
OS: Windows 7 → All
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Hardware: x86_64 → All
Version: 4.2.5 → Production
I had a new qa contributor report today she could not set flags for status-firefox20 for a bug she was verifying. I had to add her to canconfirm for that to happen. I'm not sure if that's how things are supposed to be, or if that's part of this bug.
(Assignee)

Comment 3

6 years ago
(In reply to Liz Henry :lizzard from comment #2)
> I had a new qa contributor report today she could not set flags for
> status-firefox20 for a bug she was verifying. I had to add her to canconfirm
> for that to happen. I'm not sure if that's how things are supposed to be, or
> if that's part of this bug.

Thats normal. status-firefox* flags and the others in the Project/Tracking flags section are special and required different privileges than the other regular bug flags. That particular flag needs 'canconfirm' to set.

dkl
(Reporter)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
the issue with review/feedback flags exists, and is different from setting status-* flags.
reopening.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
You need to log in before you can comment on or make changes to this bug.