849229 - Unable to set requested flag without editbugs permission

Status: REOPENED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Caitlin Potter (:caitp)]

I had been asked for feedback this morning
jacek: feedback? (caitlin.potter)

But I was not able to set my feedback until asking about it and being granted editbugs permission (which I'm not sure I need).

:ted had said on IRC that extra permissions should not be required for setting requested review/feedback flags on a bug.

Comment 1

[David Lawrence [:dkl]]

I am thinking this is due to the recent change to Bugzilla::Flag->set_flag that calls out to $bug->check_can_change_field where we were not doing that before 4.2. We will need to add some code the the BMO extension to allow the change if the user is the flags requestee. Will work on a patch.

dkl

Comment 2

[Liz Henry (:lizzard)]

I had a new qa contributor report today she could not set flags for status-firefox20 for a bug she was verifying. I had to add her to canconfirm for that to happen. I'm not sure if that's how things are supposed to be, or if that's part of this bug.

Comment 3

[David Lawrence [:dkl]]

(In reply to Liz Henry :lizzard from comment #2)
> I had a new qa contributor report today she could not set flags for
> status-firefox20 for a bug she was verifying. I had to add her to canconfirm
> for that to happen. I'm not sure if that's how things are supposed to be, or
> if that's part of this bug.

Thats normal. status-firefox* flags and the others in the Project/Tracking flags section are special and required different privileges than the other regular bug flags. That particular flag needs 'canconfirm' to set.

dkl

Comment 4

[:glob ✱]

the issue with review/feedback flags exists, and is different from setting status-* flags.
reopening.