Closed Bug 849260 Opened 8 years ago Closed 8 years ago

waitForText timeouts in testBookmarksTab

Categories

(Firefox for Android :: General, defect)

x86
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 22

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

testBookmarksTab consistently reports timeouts in waitForText:

54 INFO TEST-PASS | testBookmarksTab | Bookmark Name was changed - true should equal true
waitForText timeout on about:firefox
waitForText timeout on about:firefox
55 INFO TEST-PASS | testBookmarksTab | Bookmark Link was changed - true should equal true
waitForText timeout on about:firefox
waitForText timeout on about:firefox
waitForText timeout on about:firefox


That's because the test has edited the about:firefox item and changed it to something else.
We can fix this by simply waiting for another list item.

https://tbpl.mozilla.org/?tree=Try&rev=c9112f270a7e&showall=1

This saves some test time:
INFO | automation.py | Application ran for: 0:02:40.640147
vs 
INFO | automation.py | Application ran for: 0:04:12.165705
Attachment #722824 - Flags: review?(jmaher)
Comment on attachment 722824 [details] [diff] [review]
wait for about:home instead of about:firefox

Review of attachment 722824 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #722824 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/2f4e44ec0b9a
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.