Closed Bug 849302 Opened 9 years ago Closed 9 years ago

BaselineCompiler: Fix rootingAnalysis build failure.

Categories

(Core :: JavaScript Engine, defect)

22 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: djvj, Unassigned)

References

Details

Attachments

(1 file)

Fedora64 SM(r) is red because we can't instantiated Rooted<IonCode *>.  Need to make IonCode pointers rootable.
Just makes IonCode rootable.  Doesn't add RootedIonCode because nobody really uses Rooted IonCodes yet except for Baseline.
Attachment #722879 - Flags: review?(terrence)
Depends on: 849388
Comment on attachment 722879 [details] [diff] [review]
Make IonCode rootable.

Review of attachment 722879 [details] [diff] [review]:
-----------------------------------------------------------------

I'm surprised we didn't have this already.

::: js/src/gc/RootMarking.cpp
@@ +65,5 @@
>        case THING_ROOT_VALUE:       MarkValueRoot(trc, (Value *)addr, "exact-value"); break;
>        case THING_ROOT_ID:          MarkIdRoot(trc, (jsid *)addr, "exact-id"); break;
>        case THING_ROOT_PROPERTY_ID: MarkIdRoot(trc, &((js::PropertyId *)addr)->asId(), "exact-propertyid"); break;
>        case THING_ROOT_BINDINGS:    ((Bindings *)addr)->trace(trc); break;
> +      case THING_ROOT_ION_CODE:    MarkIonCodeRoot(trc, (ion::IonCode **)addr, "exact-ioncode"); break;

Please move this up to just below the other gcthing*s, e.g. in AllocKind order.
Attachment #722879 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/d073b1e6ba69
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.