849339 - [B2G][System] Power off option not showing up in landscape mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[mlevin]

Description:
After browsing in landscape mode when long pressing power button, options appear in landscape mode.

Video of issue at  http://youtu.be/UEwzjCQny4A

Repro Steps:
1) Updated to Unagi Build ID: 20130308070202
2) Place the Unagi in landscape mode.
3) Long press power button

Expected:
Power off options to only appear in portrait mode, or if in landscape mode all 4 options should appear: "Turn on airplane mode, Silence incoming calls, Restart, Power off".

Actual:
Power off options appear in landscape mode, and only the first 3 options appear: "Turn on airplane mode, Silence incoming calls, Restart"

Repro frequency:
(3/3)

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/94927529a55f
Gaia: 87801b12cd3aac153fae84844da8f1e6455ea679

Notes:
Test Suite Name: Smoketest
Q Analysts Test Team Priority Rating: Pri 3
Video at  http://youtu.be/UEwzjCQny4A

Comment 1

[Sreenidhi]

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/94927529a55f
Gaia   87801b12cd3aac153fae84844da8f1e6455ea679
BuildID 20130308070202
Version 18.0

Tested with a Unagi device. Was able to reproduce the issue - after browsing in landscape mode and when long pressing power button, power off options appear in landscape mode, and only the first 3 options appear: "Turn on airplane mode, Silence incoming calls, Restart".

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

It seems that we'd want that menu  of options on a long press regardless of orientation so not tracking unless product comes back saying this is not the intended behaviour or has another user story here that makes this bug worth tracking. Wonder if this bug is actually invalid?

Comment 3

[mlevin]

Isblakk,

(In reply to [e-mail] from comment #2)
> It seems that we'd want that menu  of options on a long press regardless of
> orientation so not tracking unless product comes back saying this is not the
> intended behaviour or has another user story here that makes this bug worth
> tracking. Wonder if this bug is actually invalid?

If landscape mode is expected behavior, then all the options (Turn on airplane mode, Silence incoming calls, Restart, Power off) need to appear, but in landscape mode only 3 options appear (Turn on airplane mode, Silence incoming calls, Restart).

Comment 4

[Allen Maxwell]

This issue continues to be reproducible on Mozilla RIL:
Unagi Build ID: 20130405070205
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1d4c7fe3256e
Gaia: 2f64311e0f23b85c29b20be9502cbdeaee8342ae

STR:
1) open browser
2) rotate device to landscape
3) press and hold power button.

Recommend escalation to Priority 2.

Comment 5

[Wayne Chang [:wchang]]

triage apr/8 - Not blocking for leo, set as tracking. An easily recovered bug as all options are still visible when device is rotated back to portrait mode.

Comment 6

[Chris Kreinbring [:CKreinbring]]

Also seen on Leo version 20130411070205
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473
Gaia: e7e338a765e22334b40ced41489a785941382c66

Comment 7

[Nick Davidson]

Attachment: Slider bar implementation needed for landscape power options

since user unable to access "Power Off" option in landscape menu slider bar should be implemented (on a right side) so user can scroll down to select this "Power Off"  option. 
see pic attached.

Comment 8

[Chris Kreinbring [:CKreinbring]]

Still repros on Unagi 1.1 mozilla RIL
Build ID: 20130429070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/49a908f052ec
Gaia: e26eadbc598bd09c80192016c1024a4a999a5361
Version #: 18.0

Also repros on Inari 1.0.1 mozilla RIL
Build ID: 20130429070204
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2
Version #: 18.0

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Josh, you were mentioning in bug 826266 comment 1 that this screen should not have landscape mode, is this the desired behavior or should it have vertical scroll as pointed out in comment 7?

Comment 11

[Josh Carpenter [:jcarpenter]]

(In reply to Mihai Cirlanaru [:mcirlanaru] from comment #10)
> Josh, you were mentioning in bug 826266 comment 1 that this screen should
> not have landscape mode, is this the desired behavior or should it have
> vertical scroll as pointed out in comment 7?

Either solution is acceptable for this version, and we can fix more comprehensively in the next. I'd recommend first trying to force portrait mode.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #9520 - Lock orientation to portrait for sleep menu

Thanks for the info, Josh, this patch locks the orientation to portrait whenever the sleep menu comes up (from long pressing the power button).

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 744843 [details]
Pull Request #9520 - Lock orientation to portrait for sleep menu

r=me but see nits on github comments.

I am thinking that if we're polluting screen orientation status everywhere in modules rather than grouping orientation management together but it's rather simple so that's fine.

Comment 14

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks for the feedback, Alive! Updated as you suggested and merged to master:
https://github.com/mozilla-b2g/gaia/commit/5840913b484f246753dfb965673a02c09ecb81ad

Comment 15

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 744843 [details]
Pull Request #9520 - Lock orientation to portrait for sleep menu

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Sleep Menu > options list
User impact if declined: Low/Medium -- the user can't power off the phone if sleep menu is called (by long pressing the power button) in landscape apps
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: No

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 5840913b484f246753dfb965673a02c09ecb81ad to:
v1-train: 8a1d0a915e6a76f1f5950cca298d82ad2203f36b

Comment 17

[Natalya Kot [:nkot]]

confirming fix,

- sleep menu is now locked to portrait orientation 

tested on Leo running the following build:
Build  2013-05-09-07-02-05
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/84f4c17f1605
Gaia   4e7d63a83508caa391c4db164c3f68422d9ca5b6
Version 18.0