849347 - Facebook activation fails when checking for blocklisted provider

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[u279076]

Steps to Reproduce
1. Log in to www.facebook.com
2. Go to www.facebook.com/about/messenger-for-firefox
3. Click the "Turn On" button

Result:
Social toolbar buttons and sidebar fail to appear

Expected:
Social toolbar buttons and sidebar should appear

Error in Error Console:
> Error: TypeError: data is null
> Source File: resource://gre/modules/SocialService.jsm
> Line: 378

This correlates to the following code:
> 372: installProvider: function(sourceURI, data, installCallback) {
> 373:   let URI = Services.io.newURI(sourceURI, null, null);
> 374:   let principal = Services.scriptSecurityManager.getNoAppCodebasePrincipal(URI);
> 375:   let installOrigin = principal.origin;
> 376:
> 377:   let id = getAddonIDFromOrigin(installOrigin);
> 378:   if (bs.getAddonBlocklistState(id, data.version || "0") == Ci.nsIBlocklistService.STATE_BLOCKED)
> 379:     throw new Error("installProvider: provider with origin [" +
> 380:                     installOrigin + "] is blocklisted");

Upon activation in a known good build my prefs become:
> social.activeProviders = {"https://www.facebook.com":1}
> social.enabled = true
> social.provider.current = https://www.facebook.com
> social.sidebar.open = true

Upon activation in the latest Nightly my prefs become:
> social.activeProviders (does not exist)
> social.enabled = false
> social.provider.current (does not exist)
> social.sidebar.open = true

Comment 1

[u279076]

This is a recent regression as it works in Firefox Nightly 22.0a1 2013-02-27 but does not today. I'll try to narrow down the regression range further.

Comment 2

[u279076]

Last good nightly: 2013-03-06
First bad nightly: 2013-03-07
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=216ec69cc531&tochange=ee4879719f78

The only SocialAPI change I see in this pushlog is:
Bug 786133 - Need a way to discover and install additional social providers

I'm nominating this for tracking since it prevents activation of the SocialAPI.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: Handle that 'data' may not be supplied

trivial patch that fixes the problem for me.  Probably not worth making a testcase just for this (IMO anyway ;)

Comment 4

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ef4cb8c92e3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ef4cb8c92e3

Comment 6

[u279076]

Verified fixed with Firefox Nightly 22.0a1 2013-03-14.