Facebook activation fails when checking for blocklisted provider

VERIFIED FIXED in Firefox 22

Status

()

Firefox
SocialAPI
--
major
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: ashughes, Assigned: markh)

Tracking

({regression})

22 Branch
Firefox 22
regression
Points:
---

Firefox Tracking Flags

(firefox22 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Steps to Reproduce
1. Log in to www.facebook.com
2. Go to www.facebook.com/about/messenger-for-firefox
3. Click the "Turn On" button

Result:
Social toolbar buttons and sidebar fail to appear

Expected:
Social toolbar buttons and sidebar should appear

Error in Error Console:
> Error: TypeError: data is null
> Source File: resource://gre/modules/SocialService.jsm
> Line: 378

This correlates to the following code:
> 372: installProvider: function(sourceURI, data, installCallback) {
> 373:   let URI = Services.io.newURI(sourceURI, null, null);
> 374:   let principal = Services.scriptSecurityManager.getNoAppCodebasePrincipal(URI);
> 375:   let installOrigin = principal.origin;
> 376:
> 377:   let id = getAddonIDFromOrigin(installOrigin);
> 378:   if (bs.getAddonBlocklistState(id, data.version || "0") == Ci.nsIBlocklistService.STATE_BLOCKED)
> 379:     throw new Error("installProvider: provider with origin [" +
> 380:                     installOrigin + "] is blocklisted");

Upon activation in a known good build my prefs become:
> social.activeProviders = {"https://www.facebook.com":1}
> social.enabled = true
> social.provider.current = https://www.facebook.com
> social.sidebar.open = true

Upon activation in the latest Nightly my prefs become:
> social.activeProviders (does not exist)
> social.enabled = false
> social.provider.current (does not exist)
> social.sidebar.open = true
(Reporter)

Comment 1

5 years ago
This is a recent regression as it works in Firefox Nightly 22.0a1 2013-02-27 but does not today. I'll try to narrow down the regression range further.
Keywords: regression
(Reporter)

Comment 2

5 years ago
Last good nightly: 2013-03-06
First bad nightly: 2013-03-07
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=216ec69cc531&tochange=ee4879719f78

The only SocialAPI change I see in this pushlog is:
Bug 786133 - Need a way to discover and install additional social providers

I'm nominating this for tracking since it prevents activation of the SocialAPI.
Blocks: 786133
Severity: normal → major
status-firefox22: --- → affected
tracking-firefox22: --- → ?
(Assignee)

Comment 3

5 years ago
Created attachment 723802 [details]
Handle that 'data' may not be supplied

trivial patch that fixes the problem for me.  Probably not worth making a testcase just for this (IMO anyway ;)
Assignee: nobody → mhammond
Attachment #723802 - Flags: review?(mixedpuppy)
Attachment #723802 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/mozilla-central/rev/8ef4cb8c92e3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
(Reporter)

Updated

5 years ago
Keywords: verifyme

Updated

5 years ago
status-firefox22: affected → fixed
(Reporter)

Comment 6

5 years ago
Verified fixed with Firefox Nightly 22.0a1 2013-03-14.
Status: RESOLVED → VERIFIED
status-firefox22: fixed → verified
tracking-firefox22: ? → ---
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.