Rename ubuntu{32,64} to ubuntu{32,64}_vm

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

5 years ago
... to be ready for iX ubuntu test machines.
(Assignee)

Comment 1

5 years ago
Created attachment 723913 [details] [diff] [review]
tools
(Assignee)

Comment 2

5 years ago
Created attachment 723914 [details] [diff] [review]
buildbotcustom
(Assignee)

Comment 3

5 years ago
Created attachment 723915 [details] [diff] [review]
configs
(Assignee)

Comment 4

5 years ago
Created attachment 723916 [details] [diff] [review]
puppet-manifests

old platform names should be removed from puppet-manifests and tools once reconfig happens.
(Assignee)

Comment 5

5 years ago
Comment on attachment 723916 [details] [diff] [review]
puppet-manifests

Still need to test other patches.
Attachment #723916 - Flags: review?(catlee)

Updated

5 years ago
Attachment #723916 - Flags: review?(catlee) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 723916 [details] [diff] [review]
puppet-manifests

http://hg.mozilla.org/build/puppet-manifests/rev/3acac243c894
Attachment #723916 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Attachment #723913 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Attachment #723914 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Attachment #723915 - Flags: review?(catlee)
Comment on attachment 723915 [details] [diff] [review]
configs

Review of attachment 723915 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/staging_config.py
@@ -20,2 @@
>  }
>  

did you mean to modify staging_config.py like this?
Attachment #723915 - Flags: review?(catlee) → review+
Comment on attachment 723914 [details] [diff] [review]
buildbotcustom

Review of attachment 723914 [details] [diff] [review]:
-----------------------------------------------------------------

::: common.py
@@ -104,5 @@
>          'snowleopard': 'snow',
>          'fedora': 'fed',
>          'fedora64': 'fed64',
> -        'ubuntu64': 'ub64',
> -        'ubuntu32': 'ub32',

will we still need the non-vm versions here?

::: process/factory.py
@@ +5573,5 @@
>          '''
>          Return path to a python version that eithers has "simplejson" or
>          it is 2.6 or higher (which includes the json module)
>          '''
> +        if (platform in ("fedora", "fedora64", "ubuntu32_vm", "ubuntu64_vm",

and here?

we're not using the vms for talos, right?

Updated

5 years ago
Attachment #723913 - Flags: review?(catlee) → review+
(Assignee)

Comment 9

5 years ago
(In reply to Chris AtLee [:catlee] from comment #7)
> Comment on attachment 723915 [details] [diff] [review]
> configs
> 
> Review of attachment 723915 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mozilla-tests/staging_config.py
> @@ -20,2 @@
> >  }
> >  
> 
> did you mean to modify staging_config.py like this?

Yes. We don't need empty dicts there. The code below will just copy hosts from production.
(Assignee)

Comment 10

5 years ago
(In reply to Chris AtLee [:catlee] from comment #8)
> Comment on attachment 723914 [details] [diff] [review]
> buildbotcustom
> 
> Review of attachment 723914 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: common.py
> @@ -104,5 @@
> >          'snowleopard': 'snow',
> >          'fedora': 'fed',
> >          'fedora64': 'fed64',
> > -        'ubuntu64': 'ub64',
> > -        'ubuntu32': 'ub32',
> 
> will we still need the non-vm versions here?
> 
> ::: process/factory.py
> @@ +5573,5 @@
> >          '''
> >          Return path to a python version that eithers has "simplejson" or
> >          it is 2.6 or higher (which includes the json module)
> >          '''
> > +        if (platform in ("fedora", "fedora64", "ubuntu32_vm", "ubuntu64_vm",
> 
> and here?

I left "ubuntu32" and "ubuntu64" in tools only because it's hard to align changes in tools with reconfig. I'll need to remove them once the custom/configs changes are landed and masters are reconfigured. This is why I don't need to keep the old platform name here.

> we're not using the vms for talos, right?

Correct. Unittests only.
Comment on attachment 723914 [details] [diff] [review]
buildbotcustom

Review of attachment 723914 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think the changes to TalosFactory are required, but shouldn't hurt either.
Attachment #723914 - Flags: review?(catlee) → review+
(Assignee)

Comment 12

5 years ago
Comment on attachment 723913 [details] [diff] [review]
tools

http://hg.mozilla.org/build/tools/rev/15d398afc46a
Attachment #723913 - Flags: checked-in+
(Assignee)

Comment 13

5 years ago
Comment on attachment 723915 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/01e8e2a3a59c
Attachment #723915 - Flags: checked-in+
(Assignee)

Comment 14

5 years ago
http://hg.mozilla.org/build/buildbot-configs/rev/dbae7b6b5618 to fix a bustage.

Comment 15

5 years ago
Merged change(s) from this bug and I reconfigured the masters.
(Assignee)

Comment 16

5 years ago
I'll add ubuntu{32,64}_hw as a part of other bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Summary: Rename ubuntu{32,64} to ubuntu{32,64}_vm, add ubuntu{32,64}_hw platforms → Rename ubuntu{32,64} to ubuntu{32,64}_vm
(Assignee)

Comment 17

5 years ago
bustage :/ http://hg.mozilla.org/build/tools/rev/dfe700eef2f8

Updated

5 years ago
Depends on: 854116
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.