849536 - Allow GetGCThingTraceKind to work on Nursery things.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

This is the fix for GetGCThingTraceKind that was requested in Bug 841059 Comment 11. I split it off because it depends on IsInsideNursery and wasn't part of the review for Bug 841059.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 723098 [details] [diff] [review]
v0

Review of attachment 723098 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgcinlines.h
@@ +200,5 @@
> +    JS_ASSERT(thing);
> +    const Cell *cell = static_cast<const Cell *>(thing);
> +#ifdef JSGC_GENERATIONAL
> +    if (IsInsideNursery(cell->runtime(), cell))
> +        return MapAllocToTraceKind(static_cast<const JSObject *>(cell)->getAllocKind());

This should just return JSTRACE_OBJECT since only objects are stored in the nursery.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29bff4ae6417

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/29bff4ae6417