849573 - Regression: GL graphic glitches in tab menu - LG Nexus 4

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: LG Nexus 4 (Android 4.2.2) - Screenshot

Regression from bug 716403; steps: open the tab menu

See screenshot

--
LG Nexus 4 (Android 4.2.2)
Nightly (03/09)

Comment 1

[Chris Lord [:cwiiis]]

I've tried this on the most recent Nightly on a Nexus 4 wih 4.2.2 and I can't reproduce. Do you literally just open the tabs tray and that's what happens? I've tried opening it from all orientations, with a page or the home screen loaded and everything is fine (well, except for the SurfaceView not scrolling in the landscape-right orientation, but whatever...)

Comment 2

[Aaron Train [:aaronmt]]

Open and close the tab tray in portrait rapidly on about:home

Comment 3

[Aaron Train [:aaronmt]]

In my case I had content open, using 03.11's build now yielding the same problem when the tray tray rolls back up.

Comment 4

[Aaron Train [:aaronmt]]

Captured a video of it: http://www.youtube.com/watch?v=crQAtzgAqoQ&hd=1

Comment 5

[Chris Lord [:cwiiis]]

Oh, I see, was able to reproduce (though it's very hard to catch :)) - I'll defer to Lucas/Sriram on this as it doesn't/shouldn't involve Gecko...

Comment 6

[Aaron Train [:aaronmt]]

Second video: http://www.youtube.com/watch?v=psTtF6Q2uFc&hd=1

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

leaving as a tracking nom until we get a regression window

Comment 8

[Aaron Train [:aaronmt]]

(In reply to Brad Lassey [:blassey] from comment #7)
> leaving as a tracking nom until we get a regression window

Bug 716403.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

bug 848317 (duped to this) is much easier to reproduce. Just copy the URL in the url bar using the action bar button; as the action bar dismisses you will see the graphical glitch.

Comment 11

[Aaron Train [:aaronmt]]

I find dismissing the tab menu just as easy. Unrelated, I also see this on about:home https://bug846772.bugzilla.mozilla.org/attachment.cgi?id=720039 on dismissal

Comment 12

[Chris Lord [:cwiiis]]

I don't think we need a regression window, this was caused by bug 716403 and would likely be fixed by not using the LinearLayout spacer. I thought we'd talked about this?

Comment 13

[Lucas Rocha (:lucasr)]

After discussing this on IRC, we suspect bug 716403 might not be the offender here. Requesting a regression window.

Comment 14

[Aaron Train [:aaronmt]]

M-C

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ee4879719f78&tochange=cb432984d5ce

M-I

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cbf9f569d197&tochange=c1ef9a062a88

It's bug 716403 as Chris mentioned.

Comment 15

[Aaron Train [:aaronmt]]

Video I recorded earlier http://www.youtube.com/watch?v=f83KB67oZt4

Comment 16

[Chris Lord [:cwiiis]]

If I'm very quick, I can get a black area to appear similar to the video Aaron recorded on my RAZRi - It seems that cancelling the animation before it completes runs the whole animation backwards (as opposed to just the part that's necessary), but there's nothing rendered in the surface for it to animate and it just ends up with whatever junk was in the texture (I guess).

It seems like this could be fixed by cancelling the animation with the immediate flag that I added. I'm going to see if this is easy and cook up a patch.

Comment 17

[Chris Lord [:cwiiis]]

Does fix it for me :) Patch incoming.

Comment 18

[Chris Lord [:cwiiis]]

Attachment: Handle interrupted tabs tray animation more gracefully

Comment 19

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 727423 [details] [diff] [review]
Handle interrupted tabs tray animation more gracefully

Review of attachment 727423 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 20

[Chris Lord [:cwiiis]]

Thanks for your impressively fast review, unfortunately I couldn't capitalise on it because inbound was closed and I had to sleep :( Still, pushed now: https://hg.mozilla.org/integration/mozilla-inbound/rev/13efcaa536a7

Comment 22

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/13efcaa536a7

Comment 23

[Aaron Train [:aaronmt]]

That did it, nice work