Settings API: Use ObjectWrapper.jsm instead of __exposedProps__

RESOLVED FIXED in Firefox 22, Firefox OS v1.1hd

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: reuben, Assigned: reuben)

Tracking

Trunk
mozilla22
Points:
---
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:leo+, firefox22 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 723193 [details] [diff] [review]
Add __exposedProps__ recursively

Right now SettingsManager only adds __exposedProps__ to the returned setting value if it's an object, but that doesn't work if the object itself has object properties.

Not flagging for review because I don't like this patch, I think chrome wrappers should handle this transparently. Leaving this here in case changing XPConnect is not possible for some reason.
(Assignee)

Updated

5 years ago
Summary: Settings API: Saved settings that have objects inside objects are not fully accessible → Settings API: Use ObjectWrapper.jsm instead of __exposedProps__
(Assignee)

Updated

5 years ago
Attachment #723193 - Attachment is obsolete: true
(Assignee)

Comment 1

5 years ago
Created attachment 723324 [details] [diff] [review]
Use ObjectWrapper instead of __exposedProps__

This is better :)
Assignee: nobody → reuben.bmo
Attachment #723324 - Flags: review?(anygregor)
(Assignee)

Comment 2

5 years ago
Created attachment 724644 [details] [diff] [review]
Use ObjectWrapper instead of __exposedProps__

The previous version was based on a different patch so it didn't apply cleanly.
Attachment #723324 - Attachment is obsolete: true
Attachment #723324 - Flags: review?(anygregor)
Attachment #724644 - Flags: review?(anygregor)
Attachment #724644 - Flags: review?(anygregor) → review+

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/8cbb58a451d9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Blocks: 872983
(Assignee)

Comment 5

5 years ago
Blocks a leo+ bug.
blocking-b2g: --- → leo?
blocking-b2g: leo? → leo+
https://hg.mozilla.org/releases/mozilla-b2g18/rev/ec8b7bbe80a7
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-b2g-v1.1hd: --- → affected
status-firefox22: --- → fixed

Updated

5 years ago
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.