Closed Bug 849616 Opened 7 years ago Closed 7 years ago
Settings API: Use Object
Wrapper .jsm instead of __exposed Props __
Right now SettingsManager only adds __exposedProps__ to the returned setting value if it's an object, but that doesn't work if the object itself has object properties. Not flagging for review because I don't like this patch, I think chrome wrappers should handle this transparently. Leaving this here in case changing XPConnect is not possible for some reason.
Summary: Settings API: Saved settings that have objects inside objects are not fully accessible → Settings API: Use ObjectWrapper.jsm instead of __exposedProps__
Attachment #723193 - Attachment is obsolete: true
This is better :)
Assignee: nobody → reuben.bmo
Attachment #723324 - Flags: review?(anygregor)
The previous version was based on a different patch so it didn't apply cleanly.
Attachment #724644 - Flags: review?(anygregor) → review+
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Blocks a leo+ bug.
blocking-b2g: --- → leo?
You need to log in before you can comment on or make changes to this bug.