Closed Bug 849616 Opened 7 years ago Closed 7 years ago

Settings API: Use ObjectWrapper.jsm instead of __exposedProps__

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
firefox22 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: reuben, Assigned: reuben)

References

Details

Attachments

(1 file, 2 obsolete files)

Use ObjectWrapper instead of __exposedProps__
8.75 KB, patch
gwagner
: review+
Details | Diff | Splinter Review
Attached patch Add __exposedProps__ recursively (obsolete) — — Splinter Review 
Right now SettingsManager only adds __exposedProps__ to the returned setting value if it's an object, but that doesn't work if the object itself has object properties.

Not flagging for review because I don't like this patch, I think chrome wrappers should handle this transparently. Leaving this here in case changing XPConnect is not possible for some reason.
Summary: Settings API: Saved settings that have objects inside objects are not fully accessible → Settings API: Use ObjectWrapper.jsm instead of __exposedProps__
Attachment #723193 - Attachment is obsolete: true
This is better :)
Assignee: nobody → reuben.bmo
Attachment #723324 - Flags: review?(anygregor)
The previous version was based on a different patch so it didn't apply cleanly.
Attachment #723324 - Attachment is obsolete: true
Attachment #723324 - Flags: review?(anygregor)
Attachment #724644 - Flags: review?(anygregor)
Attachment #724644 - Flags: review?(anygregor) → review+
https://hg.mozilla.org/mozilla-central/rev/8cbb58a451d9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Blocks: 872983
Blocks a leo+ bug.
blocking-b2g: --- → leo?
blocking-b2g: leo? → leo+
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.