Closed
Bug 849616
Opened 10 years ago
Closed 10 years ago
Settings API: Use ObjectWrapper.jsm instead of __exposedProps__
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
People
(Reporter: reuben, Assigned: reuben)
References
Details
Attachments
(1 file, 2 obsolete files)
8.75 KB,
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
Right now SettingsManager only adds __exposedProps__ to the returned setting value if it's an object, but that doesn't work if the object itself has object properties. Not flagging for review because I don't like this patch, I think chrome wrappers should handle this transparently. Leaving this here in case changing XPConnect is not possible for some reason.
Assignee | ||
Updated•10 years ago
|
Summary: Settings API: Saved settings that have objects inside objects are not fully accessible → Settings API: Use ObjectWrapper.jsm instead of __exposedProps__
Assignee | ||
Updated•10 years ago
|
Attachment #723193 -
Attachment is obsolete: true
Assignee | ||
Comment 1•10 years ago
|
||
This is better :)
Assignee: nobody → reuben.bmo
Attachment #723324 -
Flags: review?(anygregor)
Assignee | ||
Comment 2•10 years ago
|
||
The previous version was based on a different patch so it didn't apply cleanly.
Attachment #723324 -
Attachment is obsolete: true
Attachment #723324 -
Flags: review?(anygregor)
Attachment #724644 -
Flags: review?(anygregor)
Updated•10 years ago
|
Attachment #724644 -
Flags: review?(anygregor) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cbb58a451d9
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8cbb58a451d9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Updated•9 years ago
|
blocking-b2g: leo? → leo+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/ec8b7bbe80a7
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox22:
--- → fixed
Updated•9 years ago
|
Flags: in-moztrap-
You need to log in
before you can comment on or make changes to this bug.
Description
•