849757 - B2G RIL : Support Service Provider Lock and Corperate Lock

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

From Bug 808808, we need to add support for 'Service Provider Lock'.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See TS 22.022

Clause 6, SP personalisation/
Clause 7, Corporate personalisation

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in IDL.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in RIL.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: spck and cck in RIL.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: WIP - Part 4: xpcshell tests.

I am still working on xpcshell tests for unlock cck and spck

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 724328 [details] [diff] [review]
Part 2: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in RIL.

Review of attachment 724328 [details] [diff] [review]:
-----------------------------------------------------------------

Could you add document origin in comments?

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #6)
> Comment on attachment 724328 [details] [diff] [review]
> Part 2: Add 'corporateLocked' and 'serviceProviderSoLocked' to cardState in
> RIL.
> 
> Review of attachment 724328 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Could you add document origin in comments?

Sorry I don't understand what you mean??

Comment 8

[Anshul]

This should be leo+ as it blocks a blocker.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 724327 [details] [diff] [review]
Part 1: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in IDL.

>+   * (4) Corporate depersonalization. Unlocking the corporate control key (CCK).
>    *
>-   *   unlockCardLock({lockType: "puk",
>-   *                   puk: "...",
>-   *                   newPin: "..."});
>+   *   unlockCardLock({lockType: "spck",
--------------------------------------------------------------------------
lockType should be "cck"?

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

oh , thanks

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in IDL. v2

Thanks for Anthur catching up the typos in comments.

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in RIL. v2.

addressed Vicamo's comments.

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 4: xpcshell tests.

Comment 14

[Mozilla RelEng Bot]

Try run for 7a7e96014a9d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7a7e96014a9d
Results (out of 4 total builds):
    success: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7a7e96014a9d

Comment 15

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 4: xpcshell tests. v2

Replace pin to 8 digits.

Comment 16

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c186529c4b06
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc5e49c1b9c6
https://hg.mozilla.org/integration/mozilla-inbound/rev/aea8b504b894
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2a5ad873b6

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Waiting for Bug 822522 and Bug 837755 to land on b2g18 first, otherwise my patches will get conflict.

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c186529c4b06
https://hg.mozilla.org/mozilla-central/rev/bc5e49c1b9c6
https://hg.mozilla.org/mozilla-central/rev/aea8b504b894
https://hg.mozilla.org/mozilla-central/rev/9e2a5ad873b6

Comment 19

[Lucas Adamski [:ladamski]]

Blocks a blocker.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/967c9c123eaa
https://hg.mozilla.org/releases/mozilla-b2g18/rev/f3fd20b1775d
https://hg.mozilla.org/releases/mozilla-b2g18/rev/4eaf3039bd7a
https://hg.mozilla.org/releases/mozilla-b2g18/rev/6ebbf76fe3eb

Comment 21

[Julien Wajsberg [:julienw]]

asking for tef here as a dependency for bug 857837.

Comment 22

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

For tef+,
Do we need to push all 4 patches? 
Or just need Part 2?

Comment 23

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #22)
> For tef+,
> Do we need to push all 4 patches? 
> Or just need Part 2?

I'd say yes, IHMO we should uplift the 4 patches. Is there any problem about doing that?

Comment 24

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

okay, I'll prepare those 4 patches for b2g18_v1_0_1

Comment 25

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Jaoo, should we also tef+ Bug 822522? because PERSO_STATE also has a UNKNOWN state.

Comment 26

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: (b2g18_v1_0_1) Part 1: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in IDL.

Comment 27

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: (b2g18_v1_0_1) Part 2: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in RIL.

Comment 28

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: (b2g18_v1_0_1) Part 3: spck and cck in RIL.

Comment 29

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: (b2g18_v1_0_1) Part 4: xpcshell tests.

Comment 30

[José Antonio Olivera Ortega [:jaoo]]

Yes, we should. If theses patches depend somehow on bug 822522 we should uplift it to b2g18_v1_0_1 release branch as well. Requesting tef+ flag for bug 822522 and preparing it for uplifting then.

Comment 31

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Okay, I'll re-upload my patches after rebase on your Bug 822522 patch.

Comment 32

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: (b2g18_v1_0_1) Part 1: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in IDL. v2

Comment 33

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: (b2g18_v1_0_1) Part 2: Add 'corporateLocked' and 'serviceProviderLocked' to cardState in RIL. v2

Comment 34

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: (b2g18_v1_0_1) Part 3: spck and cck in RIL. v2

Comment 35

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: b2g18_v1_0_1) Part 4: xpcshell tests. v2

Comment 36

[Daniel Coloma:dcoloma]

Anshul, can we remove the NO_UPLIFT here?

Comment 37

[Anshul]

Daniel, the support for this is already available in commercial RIL on 1.0 as per https://bugzilla.mozilla.org/show_bug.cgi?id=857837#c36.

I would suggest we uplift bug 849751 and bug 857259 as well to complete the feature.

Comment 38

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/cad23e55d613
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ce7852691fb0
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/22c235755404
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/54285d67454b