Closed Bug 849793 Opened 12 years ago Closed 12 years ago

localization of results is incorrect

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, b2g18 verified, b2g18-v1.0.1 verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
b2g18 --- verified
b2g18-v1.0.1 --- verified

People

(Reporter: evyatar, Assigned: evyatar)

Details

Attachments

(1 file)

Patch - redirect to github PR
231 bytes, text/html
crdlc
: review+
lsblakk
: approval-gaia-v1+
Details
Localization info was passed using a TLD cookie, but apparently the Homescreen can't write those. Need to change it so the localization info will be sent in the actual API request instead.
Attachment #723421 - Flags: review?(crdlc)
Attachment #723421 - Flags: review?(crdlc) → review+
Comment on attachment 723421 [details] Patch - redirect to github PR Bug caused by (feature/regressing bug #): User impact if declined: Apps returned from e.me will not be location optimized Testing completed: Risk to taking this patch (and alternatives if risky): no risk, it will only improve results String or UUID changes made by this patch:
Attachment #723421 - Flags: approval-gaia-v1?
Attachment #723421 - Flags: approval-gaia-v1? → approval-gaia-v1+
just noticed this hasn't been merged in yet. cristian- any special reason? or can you merge it in? I rebased it for today's master (3.4)
Flags: needinfo?(crdlc)
You have the r+, you can land it on master. John Ford uplifts this one on v1-train due to status-b2g18: affected
Flags: needinfo?(crdlc)
hmm I see a warning about the travis build on GH https://github.com/mozilla-b2g/gaia/pull/8577 is that OK? couldn't understand the results, is it ok to land?
aaand you merged it :) thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Travis was failing in unit test for calendar
Uplifted commit b396d31b96e29518322748de188bee5020131560 as: v1-train: 51aaf65296a10e2e72282658d0a96cfe5efe7710
status-b2g18: affected → fixed
blocking-b2g: --- → tef?
blocking-b2g: tef? → tef+
Does not apply to v1.0.1 and for some reason misses the uplift query.. please add me to needinfo if you need help uplifting the modified patch
Flags: needinfo?(evyatar)
James, just so I'm clear- you want me to cherry pick 51aaf65296a10e2e72282658d0a96cfe5efe7710 into v1.0.1?
Flags: needinfo?(evyatar) → needinfo?(jlal)
Correct or you can alternatively supply a patch that applies cleanly to v1.0.1 and I will do the uplift.
Flags: needinfo?(jlal) → needinfo?(evyatar)
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
Basically you only need to set your device to Spanish and search for something. for example 1) Set device language to Spanish 2) Go to E.me 3) Tap the Address Bar 4) Type "local" You should get relevant apps.
As per comment 15, the bug is fixed. Relevant apps. are displayed after searching the word "local" in the Address Bar. Environmental Variables: Unagi Build ID: 20130430070201 Kernel Date: Feb 21 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7 Gaia: de0f1fc6c58616b8a33fca482f1f8684d4e74e9e Environmental Variables: Unagi Build ID: 20130426070204 Kernel Date: Mar 15 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441 Gaia: c9046a7acef33328977840176ff5574720d2c74c
Status: RESOLVED → VERIFIED
status-b2g18: fixed → verified
status-b2g18-v1.0.1: fixed → verified
looks like everything is resolved here.
Flags: needinfo?(jlal)
As per comment 16, verified on Leo and Inari devices.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: