Intermittent browser_blocklist.js | blocklisted provider removed followed by other browser_social test failures and a leak

RESOLVED FIXED in Firefox 23

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: RyanVM, Assigned: markh)

Tracking

({intermittent-failure, memory-leak})

Trunk
Firefox 23
intermittent-failure, memory-leak
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=20517864&tree=Mozilla-Inbound

Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-browser-chrome on 2013-03-11 00:26:13 PDT for push 72952b8e3e81
slave: talos-r3-xp-024

00:37:55     INFO -  TEST-START | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js
00:37:55     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testSimpleBlocklist starting
00:37:55     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | blocking 'blocked'
00:37:55     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | not blocking 'good'
00:37:55     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Console message: 1362987475506	Services.Metrics.Provider.org.mozilla.addons	WARN	Add-on type without field: service
00:37:55     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | blocklist cleared
00:37:55     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testSimpleBlocklist complete
00:37:55     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testAddingNonBlockedProvider starting
00:37:55     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | added and removed provider
00:37:55     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | adding non-blocked provider ok
00:37:55     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testAddingNonBlockedProvider complete
00:37:55     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testAddingBlockedProvider starting
00:37:56     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Console message: 1362987476006	Services.Metrics.Provider.org.mozilla.addons	WARN	Add-on type without field: service
00:37:56     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Unable to add blocklisted provider
00:37:56     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testAddingBlockedProvider complete
00:37:56     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testInstallingBlockedProvider starting
00:37:56     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Unable to add blocklisted provider
00:37:56     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testInstallingBlockedProvider complete
00:37:56     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Console message: 1362987476826	Services.Metrics.Provider.org.mozilla.addons	WARN	Add-on type without field: service
00:37:56     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testBlockingExistingProvider starting
00:37:56     INFO -  WARNING: NS_ENSURE_TRUE(currentURI) failed: file e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/content/base/src/ThirdPartyUtil.cpp, line 96
00:37:57  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | blocklisted provider removed
00:37:57  WARNING -  This is a harness error.
00:37:57     INFO -  Stack trace:
00:37:57     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js :: finish :: line 129
00:37:57     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js :: tests.testBlockingExistingProvider/</</< :: line 138
00:37:57     INFO -      JS frame :: resource://gre/modules/SocialService.jsm :: <TOP_LEVEL> :: line 286
00:37:57     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
00:37:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testBlockingExistingProvider complete
00:37:57     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | finished in 1928ms

00:37:57     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_activation.js | Social:FocusChat disabled?
00:37:57     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_activation.js | Social:SharePage visible?
00:37:57     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_activation.js | socialActiveBroadcaster hidden?
00:37:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_activation.js | sub-test testActivationWrongOrigin complete
00:37:58     INFO -  WARNING: NS_ENSURE_TRUE(mMutable) failed: file e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265
00:37:58  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_activation.js | all providers removed - Got 1, expected 0
00:37:58  WARNING -  This is a harness error.
00:37:58     INFO -  Stack trace:
00:37:58     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 486
00:37:58     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_activation.js :: cbRemoved/< :: line 29
00:37:58     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_executeSoon/<.run :: line 515
00:37:58     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
00:37:58     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_activation.js | sub-test testIFrameActivation starting

etc...
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

5 years ago
OS: Windows XP → All
Hardware: x86 → All
(Assignee)

Comment 5

5 years ago
Created attachment 738922 [details] [diff] [review]
Use the SocialService 'observer' to tell us when to check the provider was removed.

This particular orange sounds to me like a simple timing issue.  setAndUpdateBlocklist does a callback - but there is nothing to suggest that everything in SocialService must have been done at this point.

The fix here uses SocialService.registerProviderListener - the same mechanism by which Social.jsm is called - we know that after that call is made, SocialService must have removed the provider.  I also removed some of the error checks - if they fail then the test simply times out, which keeps things simpler (and obviously should never happen!)
Assignee: nobody → mhammond
Attachment #738922 - Flags: review?(mixedpuppy)
Comment hidden (Treeherder Robot)
Comment on attachment 738922 [details] [diff] [review]
Use the SocialService 'observer' to tell us when to check the provider was removed.

I think we should also use the blocklist update observer when we clear the blocklist (see head.js) before finish.  That could be included here or in another bug.
Attachment #738922 - Flags: review?(mixedpuppy) → review+
(Assignee)

Comment 8

5 years ago
Created attachment 742120 [details] [diff] [review]
With additional changes

As landed with additional changes requested and reviewed via irc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c1d4cd5a9df
Attachment #738922 - Attachment is obsolete: true
Attachment #742120 - Flags: review+
(Reporter)

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5c1d4cd5a9df
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Comment hidden (Treeherder Robot)
You need to log in before you can comment on or make changes to this bug.