bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

UPDATE action doesn't work



5 years ago
5 years ago


(Reporter: ben.janicki, Assigned: Andy McKay)




(Whiteboard: p=1)



5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130307023931

Steps to reproduce:


I tried to update app :415993
with that info :
{"name": "TEst app","device_types": ["mobile","tablet","firefoxos"],"summary": " test description","support_email": "info@mippin.com","categories": [157],"payment_type": "free","description ": " test description","homepage ": "http://www.mippin.com","support_url": "http://www.mippin.com","privacy_policy": "Privacy Policy\nRefresh Mobile Ltd (\"We\") is committed to protecting and respecting your privacy.\n\nThis policy sets out the basis on which any personal data we collect from you, or that you provide to us, will be processed by us.  Please read the following carefully to understand our views and practices regarding your personal data and how we will treat it.\n\nFor the purpose of the Data Protection Act 1998 (the Act), the data controller is Refresh Mobile Ltd, a company incorporated in England and Wales, Company Number 05403378.\n\nINFORMATION WE MAY COLLECT FROM YOU\n\nWe may collect and process the following data about you:\n\u2022    Information that you provide by filling in forms on our site. This includes information provided at the time of registering to use our site, subscribing to our service, posting material or requesting further services. We may also ask you for information if you report a problem with our site.\n\u2022    If you contact us, we may keep a record of that correspondence.\n\u2022    We may also ask you to complete surveys that we use for research purposes, although you do not have to respond to them.\n\u2022    Details of transactions you carry out through our site and of the fulfilment of your orders.\n\u2022    Details of your visits to our site (including, but not limited to, traffic data, location data, weblogs and other communication data, whether this is required for our own billing purposes or otherwise) and the resources that you access.\n\u2022    Details provided to us in the process of building a mobile application on our site, for example, your name or your job title.\n\nIP ADDRESSES\n\nWe may collect information about your computer, including where available your IP address, operating system and browser type, for system administration and to report aggregate information to our advertisers. This is statistical data about our users' browsing actions and patterns, and does not identify any individual.\n\nCOOKIES\n\nOur website uses cookies to distinguish you from other users of our website. This helps us to provide you with a good experience when you browse our website and also allows us to improve our site.\n\nWHERE WE STORE YOUR PERSONAL DATA\n\nThe data that we collect from you may be transferred to, and stored at, a destination outside the European Economic Area (\"EEA\"). It may also be processed by staff operating outside the EEA who work for us or for one of our suppliers. Such staff maybe engaged in, among other things, the fulfilment of your order, the processing of your payment details and the provision of support services. By submitting your personal data, you agree to this transfer, storing or processing. We will take all steps reasonably necessary to ensure that your data is treated securely and in accordance with this privacy policy.\n\nAll information you provide to us is stored on our secure servers. Any payment transactions will be encrypted. Where we have given you (or where you have chosen) a password which enables you to access certain parts of our site, you are responsible for keeping this password confidential. We ask you not to share a password with anyone.\n\nUnfortunately, the transmission of information via the internet is not completely secure. Although we will do our best to protect your personal data, we cannot guarantee the security of your data transmitted to our site; any transmission is at your own risk. Once we have received your information, we will use strict procedures and security features to try to prevent unauthorised access.\n\nUSES MADE OF THE INFORMATION\n\nWe use information held about you in the following ways:\n\u2022    To ensure that content from our site is presented in the most effective manner for you and for your computer.\n\u2022    To provide you with information, products or services that you request from us or which we feel may interest you, where you have consented to be contacted for such purposes.\n\u2022    To carry out our obligations arising from any contracts entered into between you and us.\n\u2022    To allow you to participate in interactive features of our service, when you choose to do so.\n\u2022    To notify you about changes to our service.\n\nWe may also use your data, or permit selected third parties to use your data, to provide you with information about goods and services which may be of interest to you and we or they may contact you about these by email.\n\nIf you are an existing customer, we will only contact you by electronic means (e-mail or SMS) with information about goods and services similar to those which were the subject of a previous sale to you.\n\nDISCLOSURE OF YOUR INFORMATION\n\nWe may disclose your personal information to any member of our group, which means our subsidiaries, our ultimate holding company and its subsidiaries, as defined in section 1159 of the UK Companies Act 2006.\n\nWe may disclose your personal information to third parties:\n\u2022    In the event that we sell or buy any business or assets, in which case we may disclose your personal data to the prospective seller or buyer of such business or assets.\n\u2022    If Refresh Mobile Ltd or substantially all of its assets are acquired by a third party, in which case personal data held by it about its customers will be one of the transferred assets.\n\u2022    If we are under a duty to disclose or share your personal data in order to comply with any legal obligation, or in order to enforce or apply our terms of use and other agreements; or to protect the rights, property, or safety of Refresh Mobile Ltd, our customers, or others. This includes exchanging information with other companies and organisations for the purposes of fraud protection and credit risk reduction.\n\nYOUR RIGHTS\n\nYou have the right to ask us not to process your personal data for marketing purposes. We will usually inform you (before collecting your data) if we intend to use your data for such purposes or if we intend to disclose your information to any third party for such purposes. You can exercise your right to prevent such processing by checking certain boxes on the forms we use to collect your data.  You can also exercise the right at any time by contacting us at info@mippin.com\nOur site may, from time to time, contain links to and from the websites of our partner networks, advertisers and affiliates.  If you follow a link to any of these websites, please note that these websites have their own privacy policies and that we do not accept any responsibility or liability for these policies.  Please check these policies before you submit any personal data to these websites.\n\nACCESS TO INFORMATION\n\nThe Act gives you the right to access information held about you. Your right of access can be exercised in accordance with the Act. Any access request may be subject to a fee of $10 to meet our costs in providing you with details of the information we hold about you.\n\nCHANGES TO OUR PRIVACY POLICY\n\nAny changes we may make to our privacy policy in the future will be posted on this page and, where appropriate, notified to you by e-mail.\n\nCONTACT\n\nQuestions, comments and requests regarding this privacy policy are welcomed and should be addressed to info@mippin.com\n"}

Actual results:

 I get 202 http response which means all fine.
But then when I get status of the app - there is part of it updated but part of it cleared completely (right now my name of the app has been cleared but I had a case when support email was cleared as well).

Expected results:

It should update my data

Comment 1

5 years ago
Just to check in the log, looks like we are getting PUTs correctly. marketplace-dev.allizom.org - [07/Mar/2013:00:47:25 -0800] "POST /api/apps/preview/?app=415993&format=json HTTP/1.1" 201 347 "-" "Java/1.7.0_07" "" marketplace-dev.allizom.org - [07/Mar/2013:00:47:27 -0800] "POST /api/apps/preview/?app=415993&format=json HTTP/1.1" 201 347 "-" "Java/1.7.0_07" "" marketplace-dev.allizom.org - [07/Mar/2013:00:47:29 -0800] "POST /api/apps/preview/?app=415993&format=json HTTP/1.1" 201 347 "-" "Java/1.7.0_07" "" marketplace-dev.allizom.org - [07/Mar/2013:00:47:39 -0800] "GET /api/apps/app/415993/ HTTP/1.1" 200 611 "-" "Java/1.7.0_07" "" marketplace-dev.allizom.org - [07/Mar/2013:00:48:01 -0800] "PUT /api/apps/app/415993/ HTTP/1.1" 202 8196 "-" "Java/1.7.0_07" "" marketplace-dev.allizom.org - [07/Mar/2013:00:48:14 -0800] "GET /api/apps/app/415993/ HTTP/1.1" 200 789 "-" "Java/1.7.0_07" "" marketplace-dev.allizom.org - [07/Mar/2013:00:48:55 -0800] "POST /api/apps/status/415993/ HTTP/1.1" 400 79 "-" "Java/1.7.0_07" "" marketplace-dev.allizom.org - [07/Mar/2013:00:56:13 -0800] "PUT /api/apps/app/415993/ HTTP/1.1" 202 8209 "-" "Java/1.7.0_07" ""


5 years ago
Assignee: nobody → amckay
Whiteboard: p=1
Target Milestone: --- → 2013-03-28


5 years ago
Priority: -- → P3

Comment 2

5 years ago
When you did the PUT, did you put all the data, or just some? We note that there's two PUTs. A PUT overwrites *all* the data with the new data. A PATCH is required to update part of the data and for horrible legacy reasons that isn't possible yet.

Comment 3

5 years ago
I put data which is above. I think it is all required data but not sure if I put all possible data. I'll have access to my workspace tomorrow morning and I will check it.
But worth noticing is that some of the data was updated and some was erased even if there are values in put request.

Comment 4

5 years ago
I'm seeing:

{"error_message": {"summary": [["en-us", "This field is required."]]}}

When summary is sent in a subsequent PUT.
Summary: UPDATE action doesn't work → Error on second PUT

Comment 5

5 years ago
No this was an error in my script, can't find a way to produce issues. Without the steps to reproduce I'm at a loss.
Summary: Error on second PUT → UPDATE action doesn't work
Target Milestone: 2013-03-28 → ---

Comment 6

5 years ago
Hi Andy
Not sure what changes you have made, but I retested exactly the same example and it started to work now. 

Seems that I was able to submit the app completely using Submission API.

Thanks for help
closing based on comment 6
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.