849929 - [dialer] less iframe at startup - quicker startup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Etienne Segonzac (:etienne)]

Apparently just having the iframe node in the DOM (without loading anything in it) still cost us about 80ms.

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal

Patch proposal

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 723587 [details] [diff] [review]
Patch proposal

Working perfectly, 'pata negra' as always.

Thanks!

Comment 3

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/8333996b0bd0ac3f186d4b399aca074772299b31

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

asking tef? and tracking? for these 80ms in the dialer, seems worth it.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> asking tef? and tracking? for these 80ms in the dialer, seems worth it.

+1000 they are more than worthy and the change is safe.

Comment 6

[Michael Vines [:m1] [:evilmachines]]

(tef+ as 80ms sounds great to me, and Francisco says it's safe :))

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 8333996b0bd0ac3f186d4b399aca074772299b31
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train)

Comment 8

[Etienne Segonzac (:etienne)]

Apparently the uplift is going to be non-trivial unless we uplift bug 838020 too.

Comment 9

[Michael Vines [:m1] [:evilmachines]]

(ok, that invalidates the assumption made in comment 6 to + this bug.   The extra 80ms is now sounding like it comes at too high a price)

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

bug 838020 has now been uplifted

Comment 11

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

Etienne, can you confirm the uplift is easier now ?

Comment 12

[Etienne Segonzac (:etienne)]

(In reply to Julien Wajsberg [:julienw] from comment #11)
> Etienne, can you confirm the uplift is easier now ?

Currently not, I'm not sure bug 838020 is on v1-train...

Comment 13

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

seems right.

(and removing tef? as this will never be on v1.0.1 anyway).

John, what was comment 10's meaning ?

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Well, we tef-'d this bug because 838020 wasn't on v1-train.  Bug 838020 is now on v1-train, so I don't know if we want to re-tef+ this bug or not.

Comment 15

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

|git log --grep='838020' v1-train| returns nothing and you didn't pushed the commit hash for v1-train in Bug 838020, that's why I'm asking :-)

Also, tef+ is for going to v1.0.1. I guess we'll have to ask an approval to to fo v1-train now.

Comment 16

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

Comment on attachment 723587 [details] [diff] [review]
Patch proposal

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: more time to launch dialer
Testing completed: 
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:

Comment 17

[Alex Keybl [:akeybl]]

(In reply to Julien Wajsberg [:julienw] from comment #16)
> Comment on attachment 723587 [details] [diff] [review]
> Patch proposal
> 
> NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to
> better understand the B2G approval process and landings.
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): 
> User impact if declined: more time to launch dialer
> Testing completed: 
> Risk to taking this patch (and alternatives if risky):
> String or UUID changes made by this patch:

This form is missing a few things.

Comment 18

[Ben Francis [:benfrancis]]

Comment on attachment 723587 [details] [diff] [review]
Patch proposal

a+me if this can be uplifted cleanly, clear buy-in from partners, low risk startup performance improvement for critical app.

And yes Julien, fill in the form! ;)

Comment 19

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

Thanks (I was about to ask Etienne ;) )

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 8333996b0bd0ac3f186d4b399aca074772299b31 as:
v1-train: 0b4aaa9b90b80e3b6363ad040ec384262fabb693