849955 - Add a way to exit fennec on ouya

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

On the latest ouya firmware, the "home" button is mapped to the menu, so there's no way to get out of fennec. Killing it via adb resurrects it immediately as well, presumably because ouya's firmware is "helpfully" restarting it for some reason or another.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

If HOME is MENU, how do other apps handle this situation?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Put back quit button for non-touchscreen devices. You can't swipe-kill the app if there's no touchscreen.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> If HOME is MENU, how do other apps handle this situation?

The app store on ouya isn't working yet so I don't have any other apps to try :(

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 723618 [details] [diff] [review]
Patch

Review of attachment 723618 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 5

[Nick Badal ([e-mail])]

In the new update, a single tap is MENU, but a double tap is HOME. (Also a long press is HOME on post-devkit controllers) :)

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Nick Badal ([e-mail]) from comment #5)
> In the new update, a single tap is MENU, but a double tap is HOME. (Also a
> long press is HOME on post-devkit controllers) :)

Ah, good to know, thanks. I think this patch is still good to have since there's no other way to fully exit Fennec. IIRC you have an aggressive activity killer but the Gecko process itself will continue to run in the background until it is OOM-killed.

I landed this on inbound and then belatedly realized that I was using API level 16 classes (InputManager) without the appropriate checks so I backed it out:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecc5ce4b7632
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f0aec2baecc

New patch coming.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch (v2)

Now with proper version checks. Sorry for the churn.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08449d84f18d

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/08449d84f18d