Status

Firefox OS
Gaia
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Offending commits:

https://github.com/mozilla-b2g/gaia/commit/d7f7c66a3f296e32a095393cd767022819fc102f
https://github.com/mozilla-b2g/gaia/commit/3261462372988f8548a6ebe58ba028c1e298f4d0
https://github.com/mozilla-b2g/gaia/commit/33f7c5e051f435bf6b4592871a7af5e63e80eb7b
https://github.com/mozilla-b2g/gaia/commit/e581f10978fd18f56b7c0393d3ab4b263b0d483a

Produces these errors:

make lint
Skipping 45 file(s).
----- FILE : /home/travis/build/mozilla-b2g/gaia/apps/browser/js/browser.js -----
Line 167, E:0011: Missing semicolon after function assigned to a variable

----- FILE : /home/travis/build/mozilla-b2g/gaia/apps/communications/contacts/js/contacts_list.js -----
Line 243, E:0013: No semicolon is required to end a code block

----- FILE : /home/travis/build/mozilla-b2g/gaia/apps/communications/gmail/test/unit/gmail_connector_test.js -----
Line 122, E:0110: Line too long (81 characters).

----- FILE : /home/travis/build/mozilla-b2g/gaia/apps/system/js/icc_cache.js -----
Line 68, E:0110: Line too long (81 characters).
Line 74, E:0110: Line too long (82 characters).

Found 5 errors, including 0 new errors, in 4 files (597 files OK).
(Assignee)

Comment 1

5 years ago
Created attachment 723699 [details]
Github pull request pointer

Fix the linter!
Attachment #723699 - Flags: review?(fabrice)
(Assignee)

Comment 2

5 years ago
Comment on attachment 723699 [details]
Github pull request pointer

I'm going to land this as it's changing *zero* functionality, and turns the travis build from red -> green.
Attachment #723699 - Flags: review?(fabrice)
(Assignee)

Comment 3

5 years ago
Landed in master: https://github.com/mozilla-b2g/gaia/commit/ae4e34c1a3f47f28899e6bbb00713457133613f6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

5 years ago
Created attachment 724481 [details]
Github pull request pointer part 2
You need to log in before you can comment on or make changes to this bug.