850055 - Clicking on Reviewer Tools/Lookup tool buttons open an empty browser window

Status: RESOLVED DUPLICATE of bug 849917

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Launch the marketplace-dev app on your unagi phone
2. Log in as an admin
3. In the Settings page, click on "Reviewer Tools" or "Lookup Tool"

expected behavior:
Reviewer Tools landing page or the Lookup tool page open within the browser

observed behavior:
Clicking on Reviewer Tools/Lookup tool buttons open an empty browser window

Comment 1

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj 82[:krupa] from comment #0)
> observed behavior:
> Clicking on Reviewer Tools/Lookup tool buttons open an empty browser window

This sounds like a regression in Gaia. `target="_blank"` historically has opened the links in the Browser from within in app. Has the behaviour changed?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

CC'ing jsmith.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> (In reply to krupa raj 82[:krupa] from comment #0)
> > observed behavior:
> > Clicking on Reviewer Tools/Lookup tool buttons open an empty browser window
> 
> This sounds like a regression in Gaia. `target="_blank"` historically has
> opened the links in the Browser from within in app. Has the behaviour
> changed?

Yup, that's right. I thought we had a bug on this recently for other reproducible cases.

Ben - Do you know?

Comment 4

[Jason Smith [:jsmith]]

I can reproduce on b2g18. Will check on v1.01 as well to be safe.

Comment 5

[Jason Smith [:jsmith]]

Doesn't reproduce on v1.01.

Comment 6

[Ben Francis [:benfrancis]]

Could be a duplicate of bug 849917

I've been able to reproduce this on my Unagi with one of the nightly production builds and today's OTA update, but I'm not sure what branch of Gaia that uses?

I can't reproduce it on the latest master.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I believe it may be a dup of https://bugzilla.mozilla.org/show_bug.cgi?id=849917.  Since I don't have admin access I can't be certain.  I tried with Market-place -> settings -> Feedback -> get hold.

Comment 8

[Jason Smith [:jsmith]]

Yup, definitely dupe after seeing the video on that bug. I'll move the noms over to that bug then.