BaselineCompiler: Remove some unused code, cleanup

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
Posted patch PatchSplinter Review
The patch removes some unused code and fixes a leak. We suppress GC during compilation now (see AutoEnterAnalysis) so this also removes the auto rooter for BaselineCompiler.
Attachment #723870 - Flags: review?(kvijayan)
Comment on attachment 723870 [details] [diff] [review]
Patch

Review of attachment 723870 [details] [diff] [review]:
-----------------------------------------------------------------

What's the leak being fixed here?  (Looks good otherwise..)
Attachment #723870 - Flags: review?(kvijayan) → review+
Assignee

Comment 2

6 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/469dbe86aab5

(In reply to Kannan Vijayan [:djvj] from comment #1)
> What's the leak being fixed here?  (Looks good otherwise..)

There was a cx->new_<LifoAlloc> without a delete. The patch just uses stack allocation.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.