850196 - Edit Listing button is not displayed in portrait mode

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Reviewer Tools, defect)

Description

[Cristian Boldan]

Attachment: edit listing button

Steps to reproduce:
1. Open Reviewer Tools on FF OS browser or Nightly (Android)
2. Tap on a listed app 
3. Turn your device to landscape mode

Expected results:
"Edit Listing" button is displayed in both portrait and landscape view.

Actual results:
"Edit Listing" button is only visible on landscape view only on Android. In FF OS is not displayed at all.

Notes/Issues:
Verified on FF OS browser and Nightly (Android 4.1.1)
Attaching screenshot for this issue.

Comment 1

[Wil Clouser [:clouserw]]

Didn't basta fix this last night when the buttons weren't showing up at all?

Comment 2

[Matt Basta [:basta]]

I got the install button back (the bar had been hidden altogether at <400px). I did notice that on those small screens, the Edit Listing button is hidden. This is done explicitly. ngoke would know more about that.

I'd imagine that if you're on a screen smaller than 400px wide, you shouldn't be using the Edit Listing button and I'm inclined to WONTFIX this.

Comment 3

[krupa raj[:krupa]]

(In reply to Matt Basta [:basta] from comment #2)
> I got the install button back (the bar had been hidden altogether at
> <400px). I did notice that on those small screens, the Edit Listing button
> is hidden. This is done explicitly. ngoke would know more about that.
> 
> I'd imagine that if you're on a screen smaller than 400px wide, you
> shouldn't be using the Edit Listing button and I'm inclined to WONTFIX this.

Isn't the firefox OS phone less than 400px wide?

Comment 4

[Matt Basta [:basta]]

(In reply to krupa raj 82[:krupa] from comment #3)
> Isn't the firefox OS phone less than 400px wide?

Yes. Don't the reviewers also have laptops?

If we're telling our reviewers to edit app listings using the crappy keyboard on FXOS phones, then we've got another thing coming.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Matt Basta [:basta] from comment #4)
> (In reply to krupa raj 82[:krupa] from comment #3)
> > Isn't the firefox OS phone less than 400px wide?
> 
> Yes. Don't the reviewers also have laptops?
> 
> If we're telling our reviewers to edit app listings using the ****
> keyboard on FXOS phones, then we've got another thing coming.

Krupa is saying that the button should still look okay on mobile. After you click the button, that might look ugly yes. But the Reviewer Tools are getting mobilified.

Comment 6

[Matt Basta [:basta]]

And I'm saying that I recognize that, but this is a use case that we specifically should be disallowing because it involves text entry on critical user-facing fields via the FXOS keyboard. Having it be mobile is fine, and showing the button is trivial, but I'm saying that we explicitly shouldn't be allowing it. If a reviewer needs to edit an app's listing page, I don't see an issue with them needing to switch to their laptop to make their changes if it means that there's going to be less chance of them borking up the app's listing page.