Closed
Bug 850259
Opened 13 years ago
Closed 13 years ago
Mozillians Privacy Controls: L10N review
Categories
(Participation Infrastructure :: Phonebook, defect)
Participation Infrastructure
Phonebook
Tracking
(Not tracked)
VERIFIED
FIXED
2013-03-28
People
(Reporter: hoosteeno, Assigned: pascalc)
References
Details
(Whiteboard: [qa-])
We have a goal this quarter to launch a small new featureset on Mozillians that will include a handful of new strings.
Our project will create the possibility that Mozillians users can make certain fields on their profiles more public. You can read all about it here:
https://wiki.mozilla.org/Mozillians/Releases/Privacy_Controls
The strings are under development here:
https://mozillians.etherpad.mozilla.org/privacy-controls-strings
These strings will fit into the L10N workflow already established, and there aren't very many. So our plan is to just run a string merge to get them into Verbatim as soon as they're ready. However, :pascalc asked that we send him a link to the staged site and a link to the strings so he can review before we run a string merge.
| Reporter | ||
Comment 1•13 years ago
|
||
Nearly all of the strings have landed in our Privacy Controls staging area.
Here are the final strings:
https://mozillians.etherpad.mozilla.org/privacy-controls-strings
Here is the staging area:
https://mozillians-dev.allizom.org/en-US/user/edit
One string (the first one on the etherpad) is in a PR, and will be deployed very soon:
https://github.com/mozilla/mozillians/pull/437/files
| Assignee | ||
Comment 2•13 years ago
|
||
Pull request 437 does not cause any l10n problem, but that bug is in the wrong component as it is not a www.mozilla.org bug
| Reporter | ||
Comment 3•13 years ago
|
||
I'm changing the component.
Pull request 437 is only one of many changes described in the etherpad linked in comment 1. Except for pull request 437, all of the other changes are deployed to the staging area linked in comment 1.
Thanks!
Component: L10N → Phonebook
Product: www.mozilla.org → Community Tools
Target Milestone: --- → 2013-03-28
Version: unspecified → other
| Assignee | ||
Comment 4•13 years ago
|
||
Do you have pointers to the pull requests that added strings corresponding to the demo server?
| Reporter | ||
Comment 5•13 years ago
|
||
I'm digging through the commits to the privacy branch of mozilla/mozillians. The below commits include many of the string changes:
https://github.com/mozilla/mozillians/commit/21584661955e163d446bf43bf225733917113d07
https://github.com/mozilla/mozillians/commit/87cd46813391939c22776de491d9e0d2f612bb18
https://github.com/mozilla/mozillians/commit/a8357fe05614368fabaf4087be695c9937b9601b
https://github.com/mozilla/mozillians/commit/46a063149c4f1c8ca96d2fa286b27539b8eb22f7
https://github.com/mozilla/mozillians/commit/d0a2273558cec157e022fc3642c1efa96812b12c
| Assignee | ||
Comment 6•13 years ago
|
||
Everything looks good except this one:
https://github.com/mozilla/mozillians/commit/d0a2273558cec157e022fc3642c1efa96812b12c
+ <option value="#">-- View as --</option>
+ <option value="public">Public</option>
+ <option value="mozillians">Mozillians</option>
+ <option value="all">All</option>
The value options are not enclosed in l10n calls.
| Reporter | ||
Comment 7•13 years ago
|
||
Comment 8•13 years ago
|
||
Commit pushed to master at https://github.com/mozilla/mozillians
https://github.com/mozilla/mozillians/commit/8d9e3d8c2358c1dc3eb120dc8ecbd3dd2f0e1544
[bug 850259] Translate strings
| Reporter | ||
Comment 9•13 years ago
|
||
The new Mozillians privacy controls are in staging and tagged for a 3/28 release.
https://mozillians.allizom.org/en-US/user/edit/
| Reporter | ||
Comment 10•13 years ago
|
||
Pascal, is there any more L10N review, or is this bug resolved? Thanks!
Flags: needinfo?(pascalc)
| Assignee | ||
Comment 11•13 years ago
|
||
From a purely strings point of view, I think we are good, but I am noticing in the site a couple of things that bother me a bit:
* The checkboxes that says something like 'I accept that you keep my data as explained in Mozilla privacy policy" has no link to the privacy policy, if the link is to be added later, you have to make sure that the string has the relevant part of the text to be linked marked up.
* The list of countries does not seem to be localized, if it is localizable, please import the country names from Firefox source code for consistency and so as to avoid having hundreds (tedious) more strings to translate.
Flags: needinfo?(pascalc)
| Reporter | ||
Comment 12•13 years ago
|
||
Great, then I'll close this bug.
Pascal, regarding your two points:
1) there's a bug 740989 for the checkbox issue you mention
2) I created bug 854487 for the localized country names, but I'm not sure I understand the actual mechanics of it. Could you please update bug 854487 with your ideas?
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•