Closed Bug 850335 Opened 9 years ago Closed 9 years ago

Work - context menu overflow

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

All
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jbecerra, Assigned: rsilveira)

References

Details

(Whiteboard: feature=work)

Attachments

(1 file, 2 obsolete files)

Tested on 2013-03-12 on nightly built from http://hg.mozilla.org/mozilla-central/rev/7433bc4545c9

While testing bug 844370 I found that if you summon a context menu on the edge of the screen, the text overflows, for example on the right edge. It should work as in IE where the right edge of the context menu is aligned with the right edge of the screen.

Steps:
1. In metro mode go to http://advrider.com/forums/
2. There is a tiny little up arrow on the upper right hand side of the screen, just below the "Oddometer" column.
3. Long tap to bring up the context menu

Expected: Context menu right edge should align with the edge of the screen.

Actual: Context menu overflow
Priority: -- → P2
See Also: → 844370
Whiteboard: feature=work
Summary: work - context menu overflow → defect - context menu overflow
Whiteboard: feature=work → feature=defect
Assignee: nobody → rsilveira
Summary: defect - context menu overflow → Work - context menu overflow
Whiteboard: feature=defect → feature=work
Comment on attachment 724132 [details] [diff] [review]
Moving context menu to the edge when it overflows.

r=mbrubeck with one change:

>     if (aX < 0)
>       aX = 0;

I think the new "else" block should be added to the statement above...

>     if (aY < 0 && aPositionOptions.moveBelowToFit) {
>       // show context menu below when it doesn't fit.
>       aY = aPositionOptions.yPos;
>     } else if (aY < 0) {
>       aY = 0;
>+    } else if (aX + width > screenWidth){
>+      aX = screenWidth - width - 2*kPositionPadding;
>     }

...instead of this one, since we want to test aX overflow regardless of aY's value.
Attachment #724132 - Flags: review?(mbrubeck) → review+
Attached patch Updates after review (obsolete) — Splinter Review
Thanks for the review.
Attachment #724132 - Attachment is obsolete: true
Attachment #724164 - Flags: checkin?
Attached patch Correcting patchSplinter Review
Sorry, forgot to qrefresh.
Attachment #724164 - Attachment is obsolete: true
Attachment #724164 - Flags: checkin?
Attachment #724173 - Flags: checkin?(mbrubeck)
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ea59ba4f9be
Status: NEW → ASSIGNED
OS: Windows 8 → Windows 8 Metro
Hardware: x86_64 → All
Attachment #724173 - Flags: checkin?(mbrubeck) → checkin+
Blocks: 844658
https://hg.mozilla.org/mozilla-central/rev/6ea59ba4f9be
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.