Closed Bug 850367 Opened 11 years ago Closed 11 years ago

Page-worker redirect leaves out content script

Categories

(Add-on SDK Graveyard :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: georgestavrev, Assigned: jsantell)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.22 (KHTML, like Gecko) Chrome/25.0.1364.155 Safari/537.22

Steps to reproduce:

I created a Page-worker that includes a content script file and a url.


Actual results:

After my content script interacted with the page, the page redirected. On the new redirected page, the content scripts were not loaded.


Expected results:

The content scripts should have been loaded or there should be a way for me to interact and load the scripts again on the redirected page.
Assignee: nobody → jsantell
Blocks: 685359
No longer blocks: 685359
Attached file GH Pull Request #959
Attachment #740407 - Flags: review?(rFobic)
Attachment #740407 - Flags: review?(rFobic) → review-
Attached file GH Pull Request 1003
Attachment #751904 - Flags: review?(rFobic)
Comment on attachment 751904 [details]
GH Pull Request 1003

Awesome! Thanks a lot for baring with me and many update requests. One tiny thing I commented about is confusing naming in one function, would be great if you could address that before landing! No more reviews are required!

Thanks again for all the work!
Attachment #751904 - Flags: review?(rFobic) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/3d6b2bb395e48072f96339c9a326a4a3ff2700a3
Bug 850367 Page worker follows redirect, refactor match patterns for page-mods

https://github.com/mozilla/addon-sdk/commit/7f15ba4812dcf829e4b93262bab1e2b6fa222c50
Merge pull request #1003 from jsantell/page-worker-redirect

Fix Bug 850367 Detraitified page worker, r=@gozala
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: