850386 - [Calendar] Zero based alarms not displaying on event view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[Kevin Grandon :kgrandon]

Cloning this bug so flags will stick as this needs to go with the event bugs.

I made a mistake somewhere and alarms that start at the beginning of the event are not displaying on the view event page.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 2

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/f65f5c7182c62240af5d7c41e904db9df1f11135

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 f65f5c7182c62240af5d7c41e904db9df1f11135
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 4

[Kevin Grandon :kgrandon]

Uplifted to v1-train: 25a6f27f5270156a217c7d0f3234946cf62a5354

Comment 5

[Jason Smith [:jsmith]]

Completed a lot of exploratory testing on this today and filed some bugs appropriately. There's more formal testing that will come from this soon, but we can mark this verified for now that this definitely has been initially looked at.

Comment 6

[:CSchmoeckel]

In MozTrap added Calendar Suite Test Case #9011 - [Calendar] Verify that alarms that start at the time of the event are displayed on the View Event page