850396 - Right half of content is black until device is rotated on Nexus S

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[:Margaret Leibovic]

Attachment: right half of content is black

See the attached photo. I find this happens to any page I navigate to after starting the app from a killed state, but rotating the device or putting the app in the background fixes it.

I'm seeing this on today's mozilla-central on a Nexus S running 2.3.6.

Comment 1

[Chris Lord [:cwiiis]]

This is caused by the single-tile drawing path being broken. This has never worked, but the fix in bug 842389 causes the path to get hit. Patch incoming to just disable that path for now.

Comment 2

[Chris Lord [:cwiiis]]

Attachment: Always use the single paint buffer

The single-tile drawing path is broken and bug 842389 meant it rarely(/never?) got hit - comment out the code that could cause it to get hit until we fix it properly.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 724496 [details] [diff] [review]
Always use the single paint buffer

I would be in favor of uplifting this. This only removes a buggy fast path.

Comment 4

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d0ad849d2bd0

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 724496 [details] [diff] [review]
Always use the single paint buffer

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Corrupt/missing content
User impact if declined: Bad, obvious rendering glitches in not-too-uncommon circumstances
Testing completed (on m-c, etc.): Local testing, just disables a faulty code-path that we thought was already disabled
Risk to taking this patch (and alternatives if risky): Low, required for bug 842389
String or UUID changes made by this patch: None

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 724496 [details] [diff] [review]
Always use the single paint buffer

Taking this to branches to help with issues in bug 842389 - we'll want to verify this doesn't cause regressions in the beta building today, if it does we'll back both 842389 and this fix from our next-to-last beta and let it all ride the trains.

Comment 7

[Chris Lord [:cwiiis]]

Pushed to aurora and beta:

https://hg.mozilla.org/releases/mozilla-aurora/rev/669a4b33fa4b
https://hg.mozilla.org/releases/mozilla-beta/rev/2d2e876059b8

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d0ad849d2bd0

Comment 9

[Paul Feher]

Verified on Firefox for Android 21.0b7 using: Nexus 4 (4.2.2) and Samsung Galaxy R (2.3.4)