Closed Bug 850408 Opened 9 years ago Closed 9 years ago

Remove some Snow Leopard OS version checks

Categories

(Core :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22
Tracking Status
firefox21 --- wontfix
firefox22 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(2 files)

Neither Firefox nor SeaMonkey support versions of Mac OS X before 10.6 (Snow Leopard).
Attachment #724133 - Flags: review?(joshmoz)
Now that neither Firefox nor SeaMonkey support versions of Mac OS X before 10.6 (Snow Leopard):

1. Remove nsStackWalk check for Leopard returning incorrect symbol "pthread_cond_wait$UNIX2003" instead of "new_sem_from_pool" (bug 696376).

2. Wrap #ifdef DEBUG because OnLionOrLater() is only called within a MOZ_ASSERT().

Would you prefer to keep these checks in the code to preserve this hard-earned knowledge about Leopard's quirks? Can the following gCriticalAddress.mAddr check be simplified if we know we won't hit two "pthread_cond_wait$UNIX2003" frames because we only run on 10.6+?

https://hg.mozilla.org/mozilla-central/annotate/c9a74f4ee1f7/xpcom/base/nsStackWalk.cpp#l77
Attachment #724140 - Flags: review?(benjamin)
Attachment #724140 - Flags: feedback?(respindola)
Attachment #724133 - Flags: review?(joshmoz) → review+
(In reply to Chris Peterson (:cpeterson) from comment #1)
> Created attachment 724140 [details] [diff] [review]
> part-2-snow-leopard-nsStackWalk.patch
> 
> Now that neither Firefox nor SeaMonkey support versions of Mac OS X before
> 10.6 (Snow Leopard):
> 
> 1. Remove nsStackWalk check for Leopard returning incorrect symbol
> "pthread_cond_wait$UNIX2003" instead of "new_sem_from_pool" (bug 696376).
> 
> 2. Wrap #ifdef DEBUG because OnLionOrLater() is only called within a
> MOZ_ASSERT().
> 
> Would you prefer to keep these checks in the code to preserve this
> hard-earned knowledge about Leopard's quirks?


A better compromise to removing the code might be to leave the Leopard comment but remove the code.
Attachment #724140 - Flags: review?(benjamin)
Attachment #724140 - Flags: review+
Attachment #724140 - Flags: feedback?(respindola)
Landed part 2 of 2:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31fdc925c310
Whiteboard: [keep open]
Target Milestone: --- → mozilla22
https://hg.mozilla.org/mozilla-central/rev/31fdc925c310
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.