850408 - Remove some Snow Leopard OS version checks

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: part-1-snow-leopard-gfx-xre.patch

Neither Firefox nor SeaMonkey support versions of Mac OS X before 10.6 (Snow Leopard).

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: part-2-snow-leopard-nsStackWalk.patch

Now that neither Firefox nor SeaMonkey support versions of Mac OS X before 10.6 (Snow Leopard):

1. Remove nsStackWalk check for Leopard returning incorrect symbol "pthread_cond_wait$UNIX2003" instead of "new_sem_from_pool" (bug 696376).

2. Wrap #ifdef DEBUG because OnLionOrLater() is only called within a MOZ_ASSERT().

Would you prefer to keep these checks in the code to preserve this hard-earned knowledge about Leopard's quirks? Can the following gCriticalAddress.mAddr check be simplified if we know we won't hit two "pthread_cond_wait$UNIX2003" frames because we only run on 10.6+?

https://hg.mozilla.org/mozilla-central/annotate/c9a74f4ee1f7/xpcom/base/nsStackWalk.cpp#l77

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson (:cpeterson) from comment #1)
> Created attachment 724140 [details] [diff] [review]
> part-2-snow-leopard-nsStackWalk.patch
> 
> Now that neither Firefox nor SeaMonkey support versions of Mac OS X before
> 10.6 (Snow Leopard):
> 
> 1. Remove nsStackWalk check for Leopard returning incorrect symbol
> "pthread_cond_wait$UNIX2003" instead of "new_sem_from_pool" (bug 696376).
> 
> 2. Wrap #ifdef DEBUG because OnLionOrLater() is only called within a
> MOZ_ASSERT().
> 
> Would you prefer to keep these checks in the code to preserve this
> hard-earned knowledge about Leopard's quirks?


A better compromise to removing the code might be to leave the Leopard comment but remove the code.

Comment 3

[Chris Peterson [:cpeterson]]

Landed part 1 of 2:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0531bbbb0ee1

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0531bbbb0ee1

Comment 5

[Chris Peterson [:cpeterson]]

Landed part 2 of 2:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31fdc925c310

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/31fdc925c310