Closed Bug 850425 Opened 9 years ago Closed 9 years ago

flyout panels are leaking

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 22

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Details

Attachments

(1 file)

about:memory is showing panels are still loaded after switching from a provider that supports panels to one that does not.  I switched an hour ago or so, and just noticed this.  I haven't investigated the code to see what may be happening.
it is the flyout panel that is not being released.
Summary: toolbar notification panels might be leaking → flyout panels are leaking
The flyout is not unloaded on provider change.  It will eventually get unloaded if the sidebar ever unloads - that doesn't happen often (but does happen if social is disabled, which is why we don't see it leaking in that case).  The good news is that this isn't a "leak" that grows over time - there will only ever be one flyout alive at a time.

The fix is probably to just add a SocialFlyOut.unload() call in the social:provider-set handler.
(In reply to Mark Hammond (:markh) from comment #2)

> The fix is probably to just add a SocialFlyOut.unload() call in the
> social:provider-set handler.

that's the patch I was just about to attach :)
Attached patch flyout unloadSplinter Review
haven't looked at a test for this, manual testing shows the flyout is now garbage collected after provider switch.
Assignee: nobody → mixedpuppy
Comment on attachment 724196 [details] [diff] [review]
flyout unload

drive-by - this should probably just land.
Attachment #724196 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/51069da75d3d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
I confirm that flyouts seem to clear from about:memory after a few seconds when switching between Facebook and MSN Now. Tested using Firefox 22.0b5 on Windows 7, Mac OSX 10.8, and Ubuntu 12.04 32-bit.

Please advise if more testing is needed.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.