Closed
Bug 850438
Opened 12 years ago
Closed 12 years ago
[phonedash] Clobber existing results when submitting new results
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
Details
Attachments
(2 files)
2.27 KB,
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
4.11 KB,
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
Phonedash takes the mean of *all* results for a given build, even if some of those were submitted in separate test runs. It would be nice to have the option to clobber existing results, in case a test run is suspect due to device problems or what have you.
I think the way to do this is have a new POST action on phonedash that takes a build ID (or revision) and optionally one or more devices and removes those results. This could be executed by trigger_jobs.py given the --clobber-results image for all devices or those specified by the --device option, if given.
Assignee | ||
Comment 1•12 years ago
|
||
On second thought, I think there is little value in even allowing cumulative results in the first place. When you rerun some tests, you want to erase previous results. If you really want more iterations, you can always increase the number in the s1s2 config.
Assignee: nobody → mcote
Status: NEW → ASSIGNED
Summary: [phonedash] Option to clobber results for a given build → [phonedash] Clobber existing results when submitting new results
Assignee | ||
Comment 2•12 years ago
|
||
Also in this patch, I removed some unused imports (including the silly Python 2.5 support--who cares about 2.5) and also changed the add-results URL to be consistent with the others. I'll update the example ini for autophone in that patch, but you'll have to update your ini after this all gets committed & I update the phonedash servers on mrcote.info.
Attachment #729114 -
Flags: review?(bclary)
Assignee | ||
Comment 3•12 years ago
|
||
Forgot to mention, the previous patch is for phonedash; this is for autophone.
I changed the resulturl to be to the API base (s1s2/), since now we add either add/ or delete/ to it. I also changed the random IPs in there to descriptive placeholder text. I reduced the default iterations to 5, and sorted the [htmlfiles] section.
I also had to move some initialization stuff in s1s2 up higher so that the resulturl is loaded in time to send the delete request to phonedash.
Attachment #729120 -
Flags: review?(bclary)
Comment 4•12 years ago
|
||
Comment on attachment 729114 [details] [diff] [review]
Add API to delete results
Review of attachment 729114 [details] [diff] [review]:
-----------------------------------------------------------------
r+ looks good.
Attachment #729114 -
Flags: review?(bclary) → review+
Comment 5•12 years ago
|
||
Comment on attachment 729120 [details] [diff] [review]
autophone patch to clear results before submitting
Review of attachment 729120 [details] [diff] [review]:
-----------------------------------------------------------------
r+ ditto.
Attachment #729120 -
Flags: review?(bclary) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://github.com/markrcote/phonedash/commit/02efcc357164ced3727c181290bd87f21b597fd6
https://github.com/mozilla/autophone/commit/d57e29a2ffe28d7b7f3ff0021c3f1d12c815dbee
Don't forget to update [settings]resulturl in your s1s2_config.ini.
Assignee | ||
Comment 7•12 years ago
|
||
Phonedash changes deployed to http://mrcote.info/phonedash/, /phonedash_bc/, and /phonedash_mcote/.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•