850589 - Scrolling via trackpad on devices with keybaord-dock triggers multitouch pinch-zooming

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Jostein Kjønigsen]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130307023931

Steps to reproduce:

On my Asus Transformer TF101, I attempted to scroll a webpage-page vertically using two-finger swiping on the keyboard dock's trackpad.

Two fingers, horizontally next to each other, moved in a vertical direction.


Actual results:

This was interpreted as a multi-touch event which seems to have triggered zooming as well to respond to the horizontal position of the fingers not being 100% in place.


Expected results:

Firefox should detect this as a pure scroll event and only scroll the page, and not activate pinch-zoom.

This works in all other Android-apps, including Chrome and stock browser. Is Firefox needlessly reinventing the wheel here?

Comment 1

[Aaron Train [:aaronmt]]

Can you try out Firefox Beta on Google Play and report if the same issues exist for you?

Comment 2

[Jostein Kjønigsen]

Same issue on Firefox beta.

It behaves the same way as a two-finger touch/swipe will do on the tablet-screen itself, but on the trackpad these gestures should be interpeted differently.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Can you try the build at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4649370ed8d6/try-android/ and post the logcat from when you try scrolling? I'd like to see what kind of input events are being delivered to Fennec. You can get the logcat using instructions at https://wiki.mozilla.org/Mobile/Fennec/Android#Using_aLogCat.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Based on the log I got in bug 848886 I think this might actually be fixed in Aurora. already. (And it will also be fixed in the build I linked to above). See https://bugzilla.mozilla.org/show_bug.cgi?id=848886#c13 for the technical details if you're interested.

Please let me know if this still happens in aurora/nightly or the build I linked to above.

Comment 5

[Jostein Kjønigsen]

It still happens in the aurora build linked above. I'll try to get a logcat.

Comment 6

[Jostein Kjønigsen]

Attachment: Logcat from adb logcat when using nightly.

Opened a web-page.

Scrolled a bit. Pinch zoomed a bit. Scrolled a bit.
Vertically and horizontally.

Hopefully contains enough info.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Hm, it looks like all of these events are getting reported as "touch" events even though they have source=0x2002 which is a SOURCE_MOUSE. We should be able to filter out those events and treat them differently, but I don't know if it'll be easy to map it to scrolling since it's not reporting any ACTION_SCROLL events. I don't know how the other apps handle this.

Comment 8

[Jostein Kjønigsen]

I have no idea what happens under the hood, but I can definitely confirm that this works "as expected" in stock AOSP browser based on the 4.2.2 Android codebase.

So should you decide to look further into this, you should have some existing code to base a fix/patch on.

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Do you still see the issue? 
If so, can you reproduce on Nightly for Android (http://nightly.mozilla.org/)?

Comment 10

[Jostein Kjønigsen]

I no longer have the TF101 or a equivalent device, so unfortunately I'm no longer able to verify or test a possible fix.

I've posted a link to the Asus Transformer sub on reddit, and hopefully they can provide some feedback.

http://www.reddit.com/r/asustransformer/comments/2bxqac/need_help_testing_transformerrelated_fix_for/

Comment 11

[Jostein Kjønigsen]

This user on reddit confirms it's working as it should:

http://www.reddit.com/r/asustransformer/comments/2bxqac/need_help_testing_transformerrelated_fix_for/cja4mww

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Awesome, thanks for checking!