Closed
Bug 850637
Opened 11 years ago
Closed 11 years ago
nsIOService does not pick up manual changes to the network.buffer.cache.* preferences
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: gsvelto, Assigned: gsvelto)
References
Details
Attachments
(1 file)
1.28 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
nsIOService reads the network.buffer.cache.count and network.buffer.cache.size at startup when executing nsIOService::Init() but does not react to changes to these preferences. Since nsIOService::Init() is invoked before Preferences::ResetAndReadUserPrefs() is called the value manually entered via about:config have no effect.
Assignee | ||
Comment 1•11 years ago
|
||
This simple patch adds "network.buffer.cache.count" and "network.buffer.cache.size" to the observed preferences so that nsIOService will pick up their changes correctly.
Comment 2•11 years ago
|
||
Comment on attachment 724959 [details] [diff] [review] [PATCH] Make nsIOService properly pick-up user-specified network.buffer.cache.* preferences Review of attachment 724959 [details] [diff] [review]: ----------------------------------------------------------------- I presume that gDefaultSegmentCount and gDefaultSegmentSize are aligned, so access to them is atomic. r+
Attachment #724959 -
Flags: review?(honzab.moz) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Honza Bambas (:mayhemer) from comment #2) > I presume that gDefaultSegmentCount and gDefaultSegmentSize are aligned, so > access to them is atomic. Yes, they're uint32_t globals so access to them is atomic on every architecture we support. The try run is here: https://tbpl.mozilla.org/?tree=Try&rev=995aece734c2
Keywords: checkin-needed
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c85be98a0a0
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5c85be98a0a0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•