Closed Bug 850686 Opened 7 years ago Closed 4 years ago
Remove unused marionette smoke tests
There's a few bugs that are currently being worked around in the WebQA automation: * /cache/recovery gets removed during the FOTA "flash" update, and should be recursively created after flash is completed successfully. To work around this, I forcefully "mkdir -p /cache/recovery" every time in the Jenkins job * If the --tests argument isn't provided to run-smoketests.py, you see this error: Traceback (most recent call last): File "./gecko/testing/marionette/update-smoketests/run-smoketests.py", line 56, in <module> main() File "./gecko/testing/marionette/update-smoketests/run-smoketests.py", line 42, in main for test in args.tests: TypeError: 'NoneType' object is not iterable
Marshall, is there anything to you need in order to resolve these issues?
Nope -- I actually have a patch to address these, but got side-tracked digging into the issue with initially running the update smoketests. I'll go ahead and post my patch.
I also added a new venv wrapper to fix the mozdevice errors we were seeing for local testing.
Attachment #737952 - Flags: review?(jgriffin)
Comment on attachment 737952 [details] [diff] [review] automation fixes - v1 Review of attachment 737952 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/marionette/update-smoketests/venv_smoketests.sh @@ +43,5 @@ > + > + # set up mozbase > + git clone git://github.com/mozilla/mozbase.git > + pushd mozbase > + python setup_development.py We shouldn't need to clone mozbase and run setup_development.py any longer. Marionette's setup.py has the correct dependencies, so running python setup.py develop on it (below) should be sufficient. (If run-smoketests.py or stage-update.py ever consume mozbase packages that Marionette doesn't, then you might still need to do that step, but currently they don't.)
Attachment #737952 - Flags: review?(jgriffin) → review+
Can/do these need to be adapted for Inaris, and landed?
(In reply to Stephen Donner [:stephend] from comment #5) > Can/do these need to be adapted for Inaris, and landed? Marshall? :-)
stephend, shall I make the change I propose in comment #4 and land this?
(In reply to Jonathan Griffin (:jgriffin) from comment #7) > stephend, shall I make the change I propose in comment #4 and land this? I think these tests are (very likely!) still valuable, so yes; though we should move them to Unagis, if we can, as Tony and others tell me that's currently the best platform for 1.x, going forward.
cc:ing a few folks who might be interested in picking this up.
Was this ever landed?
Jonathan, Do you know if these tests are still run? If not then we perhaps we can see about deleting this from the tree.
Pretty sure these tests were abandoned, can't recall if this was landed or not, but I don't think so
These aren't run; we can delete them.
Bug 850686: Remove dead tests from Marionette; r?jgriffin
Attachment #8660201 - Flags: review?(jgriffin)
Summary: B2G Update Tests: Fixes needed for automation → Remove unused marionette smoke tests
Comment on attachment 8660201 [details] MozReview Request: Bug 850686: Remove dead tests from Marionette; r?jgriffin https://reviewboard.mozilla.org/r/19103/#review16947 \o/
Attachment #8660201 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a772808393b18a99403054922172d3d16a320253 Bug 850686: Remove dead tests from Marionette; r=jgriffin
You need to log in before you can comment on or make changes to this bug.