Closed Bug 850720 Opened 11 years ago Closed 11 years ago

[traceback] AttributeError: 'NoneType' object has no attribute 'localized_string'

Categories

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Product:
Marketplace Graveyard
Component:
Payments/Refunds
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-03-21

People

(Reporter: andy+bugzilla, Assigned: basta)

References

Details

(Whiteboard: p=1) 

No addon.name when connecting to bango in payments setup.
 
sentry.dmz.phx1.mozilla.com/addons/marketplace-dev/group/12331/
Why is this using addon.name.localized_string? It should use unicode(addon.name) because that falls back to the default, unlocalized string IIRC.
Blocks: marketplace-payments
Priority: -- → P2
Summary: [traceback] AAttributeError: 'NoneType' object has no attribute 'localized_string' → [traceback] AttributeError: 'NoneType' object has no attribute 'localized_string'
-> basta wrote this and comment 1 sounds like an easy 1 line fix.
Assignee: nobody → mattbasta
Target Milestone: --- → 2013-03-21
Whiteboard: p=1
Version: 1.0 → 1.2
https://github.com/mozilla/zamboni/commit/07dae64d3aa7a7ecf092371f1107329c89c465f5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Does this work? I don't actually remember if addon.name falls back to the default, unlocalized string.
Does it matter what name Solitude is storing? I mean if we wanted to do it right, we'd have to send a dict of all of the translations to Solitude and let it decide which locale to use when it wants to list the app name, no?
mmm, yes, right you are! I created bug 854039

For now we can just send the default locale. Does unicode(addon.name) do that? I am asking because comment #1 was just a guess.
You need to log in before you can comment on or make changes to this bug.