Closed Bug 850799 Opened 8 years ago Closed 8 years ago

[s1s2] Run tests with and without cache enabled

Categories

(Testing :: Autophone, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcote, Assigned: bc)

References

Details

Attachments

(2 files)

For comparison, we should do two runs of each s1s2 test, one with cache enabled and one without, remembering that the first iteration of the cache-enabled run is a special case.
Assignee: nobody → bclary
Status: NEW → ASSIGNED
Attachment #726170 - Flags: review?(mcote)
Attachment #726171 - Flags: review?(mcote)
The autophone patch is applied on top of the patch in bug 851288
Duplicate of this bug: 849269
Comment on attachment 726170 [details] [diff] [review]
cache autophone patch

Review of attachment 726170 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and seems to work fine now.  Just try to keep lines < 80 characters.  (Something I admittedly sometimes bypass :)
Attachment #726170 - Flags: review?(mcote) → review+
Comment on attachment 726171 [details] [diff] [review]
cache phonedash patch

Review of attachment 726171 [details] [diff] [review]:
-----------------------------------------------------------------

::: html/index.html
@@ +50,3 @@
>          Show error bars <input name="errorbars" id="errorbars" type="checkbox"  />
>          <br />
>          Show initial only <input name="initialonly" id="initialonly" type="checkbox" />

Could you document this in one of the included text doc files, if it isn't already?  This is assuming the initial cached value is still fairly different from the uncached values--something we should probably check.

::: html/scripts/app.js
@@ +148,5 @@
>    if (hash != document.location.hash) {
>      document.location.hash = hash;
>      return false;
>    }
> +  $.getJSON('api/s1s2/data/?product=' + params.product + '&metric=' + params.metric + '&test=' + params.test + '&start=' + $('#startdate').attr('value') + '&end=' + $('#enddate').attr('value') + '&cached=' + ($('#cached').attr('checked')?'cached':'notcached') + '&errorbars=' + ($('#errorbars').attr('checked')?'errorbars':'noerrorbars') + '&initialonly=' + ($('#initialonly').attr('checked')?'initialonly':'notinitialonly'), function(data) {

Man oh man I gotta clean this up at some point. :)

::: server/handlers.py
@@ +85,5 @@
>      @templeton.handlers.json_response
>      def GET(self):
>          query, body = templeton.handlers.get_request_parms()
> +        # bc:
> +        print 'GET: query %s, body %s' % (query, body)

I think you left this in by accident.
Attachment #726171 - Flags: review?(mcote) → review+
https://github.com/markrcote/phonedash/commit/f864b4737924bdba186fb419e7c9ad615bb27d38
https://github.com/mozilla/autophone/commit/33564b1af2ee196d01e83508d5c092fe65ea81a8

After you land your build server patch, I'll go throw s1s2 and try to clean up the line lengths.

Had some git issues with the nested paths and rebase. Hopefully I fixed it properly. :/
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.